Introduce ByProducerIdOrFirstField as the default event routing
#1610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yevsyukov
changed the title
ByProducerIdOrFirstField as the default event routing
There was a problem hiding this comment.
Pull Request Overview
This PR implements miscellaneous improvements including test re-enablement after validation fixes, enhanced event routing capabilities, and documentation updates. The version is bumped from 348 to 349.
Key changes:
- Re-enabled previously disabled validation tests now that TemplateString placeholders are supported
- Added new combined routing strategy
ByProducerIdOrFirstFieldfor more flexible event routing - Enhanced JavaDoc documentation across several classes
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Version bump to 2.0.0-SNAPSHOT.349 |
| pom.xml | Version bump to 2.0.0-SNAPSHOT.349 |
| dependencies.md | Updated dependency report with new version and timestamp |
| ConstraintViolatedTest.java | Re-enabled test and updated assertions to verify error message content |
| StandTest.java | Re-enabled three nested test classes for query/topic/subscription validation |
| EventValidatorTest.java | Re-enabled event validation test and updated copyright year |
| TransactionTest.java | Re-enabled entity state validation test |
| MessageRouting.kt | Updated comment from "passed" to "given" |
| EventRouting.kt | Added new factory method for combined routing strategy |
| EventRoute.kt | Added new routing method and improved documentation |
| ByProducerIdOrFirstField.kt | New routing strategy class combining producer ID and first field routing |
| ByFirstField.kt | Reformatted JavaDoc formatting |
| EventDispatchingRepository.java | Changed routing to lazy initialization using Supplier |
| AggregateRepository.java | Changed routing to lazy initialization using Supplier |
| TestActorRequestFactory.java | Added comprehensive JavaDoc for all constructors and methods |
server/src/test/java/io/spine/system/server/ConstraintViolatedTest.java
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/io/spine/server/route/ByProducerIdOrFirstField.kt
Outdated
Show resolved
Hide resolved
armiol
reviewed
Nov 11, 2025
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov please see my comment.
server/src/main/kotlin/io/spine/server/route/ByProducerIdOrFirstField.kt
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Nov 11, 2025
Copilot finished reviewing on behalf of
alexander-yevsyukov
November 11, 2025 19:53
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
server/src/main/kotlin/io/spine/server/route/EventRouting.kt:1
- The
@CanIgnoreReturnValueannotation was removed from bothwithDefault()andwithDefaultByProducerId()methods. This is a breaking change for consumers who may be calling these methods without using the return value. WhilewithDefault()is marked@VisibleForTesting,withDefaultByProducerId()is public API, and removing this annotation could cause ErrorProne or similar static analysis tools to flag existing usages.
/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements enhanced event routing capabilities for the default routings.
Notable hanges
ByProducerIdOrFirstFieldfor more flexible event routing.TemplateStringplaceholders are supported.