Skip to content

Improved codegen in ImageSharp.Guard #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Improved codegen in ImageSharp.Guard #1333

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ddb0f
Improved codegen in ImageSharp.Guard
Sergio0694 Aug 30, 2020
e740fb6
Improved Guard.MustBeValueType<T> codegen
Sergio0694 Sep 1, 2020
e7e4c8d
Merge branch 'master' into sp/guard-codegen-improvement
JimBobSquarePants Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ImageSharp/Common/Helpers/Guard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// Licensed under the Apache License, Version 2.0.

using System;
#if NETSTANDARD1_3
using System.Reflection;
#endif
using System.Runtime.CompilerServices;
using SixLabors.ImageSharp;

Expand All @@ -20,10 +22,16 @@ internal static partial class Guard
[MethodImpl(InliningOptions.ShortMethod)]
public static void MustBeValueType<TValue>(TValue value, string parameterName)
{
if (!value.GetType().GetTypeInfo().IsValueType)
if (value.GetType()
#if NETSTANDARD1_3
.GetTypeInfo()
#endif
.IsValueType)
{
ThrowHelper.ThrowArgumentException("Type must be a struct.", parameterName);
return;
}

ThrowHelper.ThrowArgumentException("Type must be a struct.", parameterName);
}
}
}