Skip to content

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2023
Merged

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
395b08e
chore: vertical align the filter pill
mrcthms Apr 11, 2023
523e11c
chore: use micro button for clear all link:
mrcthms Apr 12, 2023
8287ed3
chore: remove transform
mrcthms Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-ravens-repair.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Tweaked the vertical alignment of elements within the `AlphaFilters` component
15 changes: 9 additions & 6 deletions polaris-react/src/components/AlphaFilters/AlphaFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {Text} from '../Text';
import {UnstyledButton} from '../UnstyledButton';
import {classNames} from '../../utilities/css';
import type {AppliedFilterInterface, FilterInterface} from '../../types';
import {Link} from '../Link';
import {HorizontalStack} from '../HorizontalStack';
import {Box} from '../Box';
import {Spinner} from '../Spinner';
import {Button} from '../Button';

import {FilterPill, SearchField} from './components';
import styles from './AlphaFilters.scss';
Expand Down Expand Up @@ -329,11 +329,14 @@ export function AlphaFilters({
styles.MultiplePinnedFilterClearAll,
)}
>
<Link onClick={handleClearAllFilters} removeUnderline>
<Text variant="bodySm" fontWeight="semibold" as="span">
{i18n.translate('Polaris.Filters.clearFilters')}
</Text>
</Link>
<Button
size="micro"
plain
onClick={handleClearAllFilters}
removeUnderline
>
{i18n.translate('Polaris.Filters.clearFilters')}
</Button>
</div>
) : null;

Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/AlphaFilters/components/FilterPill/FilterPill.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
}

.Label {
display: block;
display: flex;
padding-left: var(--p-space-05);
}
}
Expand Down