[AlphaFilters] Fixes incorrect vertical alignment within component #8913

mrcthms · 2023-04-11T09:48:35Z

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/issues/88968

WHAT is this pull request doing?

The label within active filter pills, and the "Clear all" button text were 1px lower than they should have been. This PR addresses that by putting them back where they should be.

Before:

After:

Storybook URL: https://5d559397bae39100201eedc1-kdasyocdfw.chromatic.com/?path=/story/all-components-alphafilters--with-a-resource-list

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

github-actions · 2023-04-11T09:52:27Z

size-limit report 📦

Path	Size
polaris-react-cjs	240.01 KB (-0.02% 🔽)
polaris-react-esm	156.49 KB (-0.02% 🔽)
polaris-react-esnext	218.7 KB (+0.01% 🔺)
polaris-react-css	47.21 KB (+0.01% 🔺)

mattkubej · 2023-04-11T20:39:40Z

polaris-react/src/components/AlphaFilters/AlphaFilters.scss


 .ClearAll {
  margin-left: var(--p-space-1);
+  transform: translateY(-1px);


Rather than offset this, should we solve this the same way as the other pills by using flex?

Rather than use a Link, use an UnstyledButton that uses flex .

Sounds like this suggestion did not do the trick based on a discussion on Slack. Going to approve this, so the fix can move forward.

mattkubej

Approving, but have not top hatted. Will validate changes against storybook when it finishes publishing.

@skparkk

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/[email protected] ### Major Changes - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [#8968](#8968) [`dbe68efb4`](dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/[email protected] ### Minor Changes - [#8936](#8936) [`a2c9b1d24`](a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [#8773](#8773) [`e8c5a2243`](e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8937](#8937) [`fcc543928`](fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [#8938](#8938) [`289dce569`](289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8596](#8596) [`421bb49dc`](421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [#8953](#8953) [`500eed660`](500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [#8842](#8842) [`bd64fa583`](bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [#8913](#8913) [`261355f07`](261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [#8954](#8954) [`f9366c22d`](f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [#8912](#8912) [`1cc47495a`](1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8967](#8967) [`45d978e7b`](45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [#8986](#8986) [`f70f586ee`](f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8920](#8920) [`2bad4e305`](2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [#8915](#8915) [`c8a130caf`](c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](a2c9b1d), [`e8c5a2243`](e8c5a22), [`090d09683`](090d096), [`bd64fa583`](bd64fa5), [`f1a3ad756`](f1a3ad7), [`261355f07`](261355f), [`fcc543928`](fcc5439), [`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050), [`f9366c22d`](f9366c2), [`289dce569`](289dce5), [`7f3053342`](7f30533), [`421bb49dc`](421bb49), [`500eed660`](500eed6), [`1cc47495a`](1cc4749)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…hopify#8913) ### WHY are these changes introduced? Fixes https://github.com/Shopify/web/issues/88968 ### WHAT is this pull request doing? The label within active filter pills, and the "Clear all" button text were 1px lower than they should have been. This PR addresses that by putting them back where they should be. Before: <img width="1963" alt="Screenshot 2023-04-11 at 10 38 30" src="https://user-images.githubusercontent.com/2562596/231123116-c2f1495e-7c00-4eb9-845a-e96d45b58d7d.png"> After: <img width="1963" alt="Screenshot 2023-04-11 at 10 38 16" src="https://user-images.githubusercontent.com/2562596/231123201-14fea21d-6e42-4ef4-a65b-3b40507c74e3.png"> Storybook URL: https://5d559397bae39100201eedc1-kdasyocdfw.chromatic.com/?path=/story/all-components-alphafilters--with-a-resource-list ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@skparkk

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/[email protected] ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/[email protected] ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@a2c9b1d), [`e8c5a2243`](Shopify@e8c5a22), [`090d09683`](Shopify@090d096), [`bd64fa583`](Shopify@bd64fa5), [`f1a3ad756`](Shopify@f1a3ad7), [`261355f07`](Shopify@261355f), [`fcc543928`](Shopify@fcc5439), [`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050), [`f9366c22d`](Shopify@f9366c2), [`289dce569`](Shopify@289dce5), [`7f3053342`](Shopify@7f30533), [`421bb49dc`](Shopify@421bb49), [`500eed660`](Shopify@500eed6), [`1cc47495a`](Shopify@1cc4749)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…hopify#8913) ### WHY are these changes introduced? Fixes Shopify/web#88968 ### WHAT is this pull request doing? The label within active filter pills, and the "Clear all" button text were 1px lower than they should have been. This PR addresses that by putting them back where they should be. Before: <img width="1963" alt="Screenshot 2023-04-11 at 10 38 30" src="https://user-images.githubusercontent.com/2562596/231123116-c2f1495e-7c00-4eb9-845a-e96d45b58d7d.png"> After: <img width="1963" alt="Screenshot 2023-04-11 at 10 38 16" src="https://user-images.githubusercontent.com/2562596/231123201-14fea21d-6e42-4ef4-a65b-3b40507c74e3.png"> Storybook URL: https://5d559397bae39100201eedc1-kdasyocdfw.chromatic.com/?path=/story/all-components-alphafilters--with-a-resource-list ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

@skparkk

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@e29f62e) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@1ad1a62) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@3dc9640) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/[email protected] ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@af07125) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/[email protected] ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@085d3f7) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@58136bc) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@6e0bb48) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@6d46f59) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@bc813c0) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@1dc66ee) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@b916015) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@ee7c076) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@4345b34) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@6d47345) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@05d41ad), [`80eb3ac55`](Shopify@cc8c04e), [`dbe68efb4`](Shopify@af07125)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@7e46d7e) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@05d41ad) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@ab4bbed) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@c488159) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@4ccc28a) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@751027b) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@8a81b6a) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@cc8c04e) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@085d3f7), [`e8c5a2243`](Shopify@58136bc), [`090d09683`](Shopify@7e46d7e), [`bd64fa583`](Shopify@b916015), [`f1a3ad756`](Shopify@05d41ad), [`261355f07`](Shopify@ee7c076), [`fcc543928`](Shopify@6e0bb48), [`4880e3ed7`](Shopify@1ad1a62), [`7349d4108`](Shopify@e29f62e), [`2bc90503d`](Shopify@3dc9640), [`f9366c22d`](Shopify@4345b34), [`289dce569`](Shopify@6d46f59), [`7f3053342`](Shopify@4ccc28a), [`421bb49dc`](Shopify@bc813c0), [`500eed660`](Shopify@1dc66ee), [`1cc47495a`](Shopify@6d47345)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

melodyhabbouche approved these changes Apr 11, 2023

View reviewed changes

mattkubej reviewed Apr 11, 2023

View reviewed changes

mrcthms force-pushed the mrcthms-filter-pill-v-align branch from 54969c6 to 25ea0eb Compare April 12, 2023 16:35

mattkubej approved these changes Apr 12, 2023

View reviewed changes

mrcthms added 3 commits April 12, 2023 19:20

chore: vertical align the filter pill

395b08e

chore: use micro button for clear all link:

523e11c

chore: remove transform

8287ed3

mrcthms force-pushed the mrcthms-filter-pill-v-align branch from b898615 to 8287ed3 Compare April 12, 2023 18:21

mrcthms merged commit 261355f into main Apr 12, 2023

mrcthms deleted the mrcthms-filter-pill-v-align branch April 12, 2023 19:21

shopify-github-actions-access bot mentioned this pull request Apr 12, 2023

Version Packages #8929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

Uh oh!

mrcthms commented Apr 11, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 11, 2023 •

edited

Loading

Uh oh!

mattkubej Apr 11, 2023

Uh oh!

mattkubej Apr 12, 2023

Uh oh!

mattkubej left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

[AlphaFilters] Fixes incorrect vertical alignment within component #8913

Uh oh!

Conversation

mrcthms commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

🎩 checklist

Uh oh!

github-actions bot commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

mattkubej Apr 11, 2023

Choose a reason for hiding this comment

Uh oh!

mattkubej Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

mattkubej left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mrcthms commented Apr 11, 2023 •

edited

Loading

github-actions bot commented Apr 11, 2023 •

edited

Loading