Skip to content

Conversation

@christiand93
Copy link
Member

  • Add setting to retain custom field types when using cloud logging format
  • Update documentation accordingly
  • Fix test cases failing due to async callback called too early

@christiand93 christiand93 marked this pull request as ready for review May 28, 2024 07:01
Copy link
Contributor

@nicklas-dohrn nicklas-dohrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual function looks a little bit crowded.
Besides that, only some minor oversights.

Copy link
Contributor

@nicklas-dohrn nicklas-dohrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christiand93 christiand93 merged commit eb6264d into main Sep 20, 2024
5 checks passed
@christiand93 christiand93 deleted the retain-custom-field-type branch September 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom fields always converted to strings, even if not necessary.

3 participants