-
Notifications
You must be signed in to change notification settings - Fork 432
Warning for observation APIs when used with inhabitable types & promoteValue.
#429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| import Result | ||
|
|
||
| // Observation | ||
| extension SignalProducer where Value == Never { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"`success` event is never delivered.") | ||
| public func startWithResult(_ action: @escaping (Result<Value, Error>) -> Void) -> Disposable { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func startWithValues(_ action: @escaping (Value) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| extension SignalProducer where Value == Never, Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func startWithResult(_ action: @escaping (Result<Value, Error>) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| extension SignalProducer where Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func startWithFailed(_ action: @escaping (Error) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| extension Signal where Value == Never { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"`success` event is never delivered.") | ||
| public func observeResult(_ action: @escaping (Result<Value, Error>) -> Void) -> Disposable { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func observeValues(_ action: @escaping (Value) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| extension Signal where Value == Never, Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func observeResult(_ action: @escaping (Result<Value, Error>) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| extension Signal where Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"The observer is never invoked.") | ||
| public func observeFailed(_ action: @escaping (Error) -> Void) -> Disposable { fatalError() } | ||
| } | ||
|
|
||
| // flatMap | ||
| extension SignalProducer where Value == Never { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> SignalProducer<Inner.Value, Error> where Inner.Error == Error { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> SignalProducer<Inner.Value, Error> where Inner.Error == NoError { fatalError() } | ||
| } | ||
|
|
||
| extension SignalProducer where Value == Never, Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> SignalProducer<Inner.Value, Inner.Error> { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> SignalProducer<Inner.Value, Inner.Error> where Inner.Error == Error { fatalError() } | ||
| } | ||
|
|
||
| extension SignalProducer where Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteError` instead.") | ||
| public func flatMapError<NewError>(_ transform: @escaping (Error) -> SignalProducer<Value, NewError>) -> SignalProducer<Value, NewError> { fatalError() } | ||
| } | ||
|
|
||
| extension Signal where Value == Never { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> Signal<Inner.Value, Error> where Inner.Error == Error { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> Signal<Inner.Value, Error> where Inner.Error == NoError { fatalError() } | ||
|
|
||
| } | ||
|
|
||
| extension Signal where Value == Never, Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> Signal<Inner.Value, Inner.Error> { fatalError() } | ||
|
|
||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteValue` instead.") | ||
| public func flatMap<Inner: SignalProducerConvertible>(_ strategy: FlattenStrategy, _ transform: @escaping (Value) -> Inner) -> Signal<Inner.Value, Inner.Error> where Inner.Error == Error { fatalError() } | ||
| } | ||
|
|
||
| extension Signal where Error == NoError { | ||
| @discardableResult | ||
| @available(*, deprecated, message:"Use `promoteError` instead.") | ||
| public func flatMapError<NewError>(_ transform: @escaping (Error) -> SignalProducer<Value, NewError>) -> Signal<Value, NewError> { fatalError() } | ||
| } | ||
|
|
||
| /* | ||
| func test() { | ||
| SignalProducer<Never, AnyError>.never.startWithResult { _ in } | ||
| SignalProducer<Never, NoError>.never.startWithResult { _ in } | ||
| SignalProducer<Any, NoError>.never.startWithFailed { _ in } | ||
| SignalProducer<Never, NoError>.never.startWithFailed { _ in } | ||
| Signal<Never, AnyError>.never.observeResult { _ in } | ||
| Signal<Never, NoError>.never.observeResult { _ in } | ||
| Signal<Any, NoError>.never.observeFailed { _ in } | ||
| Signal<Never, NoError>.never.observeFailed { _ in } | ||
|
|
||
| SignalProducer<Never, AnyError>.never.flatMap(.latest) { _ in SignalProducer<Int, AnyError>.empty } | ||
| SignalProducer<Never, AnyError>.never.flatMap(.latest) { _ in SignalProducer<Int, NoError>.empty } | ||
| SignalProducer<Never, NoError>.never.flatMap(.latest) { _ in SignalProducer<Int, AnyError>.empty } | ||
| SignalProducer<Never, NoError>.never.flatMap(.latest) { _ in SignalProducer<Int, NoError>.empty } | ||
| SignalProducer<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, AnyError>.empty } | ||
| SignalProducer<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, NoError>.empty } | ||
|
|
||
| Signal<Never, AnyError>.never.flatMap(.latest) { _ in SignalProducer<Int, AnyError>.empty } | ||
| Signal<Never, AnyError>.never.flatMap(.latest) { _ in SignalProducer<Int, NoError>.empty } | ||
| Signal<Never, NoError>.never.flatMap(.latest) { _ in SignalProducer<Int, AnyError>.empty } | ||
| Signal<Never, NoError>.never.flatMap(.latest) { _ in SignalProducer<Int, NoError>.empty } | ||
| Signal<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, AnyError>.empty } | ||
| Signal<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, NoError>.empty } | ||
| } | ||
| */ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bunch of test cases to verify these combinations would emit the error message. Moving them to the spec would flood the IDE with warnings, so I just commented them out. 🤦♂️