Warning for observation APIs when used with inhabitable types & promoteValue.
#429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
changed the title
promoteValue.
mdiep
reviewed
Jun 6, 2017
| Signal<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, AnyError>.empty } | ||
| Signal<Never, NoError>.never.flatMapError { _ in SignalProducer<Never, NoError>.empty } | ||
| } | ||
| */ |
Member
Author
There was a problem hiding this comment.
Just a bunch of test cases to verify these combinations would emit the error message. Moving them to the spec would flood the IDE with warnings, so I just commented them out. 🤦♂️
mdiep
approved these changes
Jun 7, 2017
Contributor
|
Just needs a changelog entry or two. |
Member
Author
|
I think it needs better error message to tell that ignoring the error message would trap at runtime & also fill in the blanks for |
Member
Author
|
@mdiep Please check. The error message are written in reduced written register btw, following the swift stdlib style. |
mdiep
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise warnings when using observation API or operators that is essentially a logic error due to
ValueorErrorbeing an inhabitable type. Please refer toInhabitableTypeGuards.swiftfor the lists of affected operators.Also note that these overloads cannot be marked as
unavailableorobsolete, or otherwise the regular version would take precedence over this.Checklist