Mark inactive "create" button as gray #244

alimirjamali · 2025-02-11T17:39:24Z

codecov · 2025-02-11T17:51:42Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.17%. Comparing base (3d5af8f) to head (96b9825).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
qubes_config/new_qube/new_qube_app.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   93.17%   93.17%   -0.01%     
==========================================
  Files          58       58              
  Lines       11051    11055       +4     
==========================================
+ Hits        10297    10300       +3     
- Misses        754      755       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qubesos-bot · 2025-02-12T07:50:09Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021620-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update

system_tests_whonix@hw7
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend@hw1
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_gui_tools@hw7
- desktop_linux_manager_create_qube: unnamed test (unknown)
- desktop_linux_manager_create_qube: Failed (test died)
  # Test died: no candidate needle with tag(s) 'new-qube-select-name'...
- desktop_linux_manager_create_qube: unnamed test (unknown)
system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_qrexec
- TC_00_Qrexec_fedora-41-xfce: test_084_qrexec_service_argument_extra_env (error)
  subprocess.CalledProcessError: Command '/usr/lib/qubes/qrexec-clien...
system_tests_misc
- TC_06_AppVM_debian-12-xfce: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b''b"stat: c...
- TC_06_AppVM_debian-12-xfce: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_debian-12-xfce: test_111_rescue_console_initrd (failure)
  AssertionError: Emergency mode not found
- TC_06_AppVM_fedora-41-xfce: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b''b"stat: c...
- TC_06_AppVM_fedora-41-xfce: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-gateway-17: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b' File: /h...
- TC_06_AppVM_whonix-gateway-17: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-gateway-17: test_111_rescue_console_initrd (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_06_AppVM_whonix-workstation-17: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b' File: /h...
- TC_06_AppVM_whonix-workstation-17: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-workstation-17: test_111_rescue_console_initrd (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_gui_tools
- desktop_linux_manager_config: unnamed test (unknown)
- desktop_linux_manager_config: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-global-config-t...

Failed tests

28 failures

system_tests_whonix@hw7
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend@hw1
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_gui_tools@hw7
- desktop_linux_manager_create_qube: unnamed test (unknown)
- desktop_linux_manager_create_qube: Failed (test died)
  # Test died: no candidate needle with tag(s) 'new-qube-select-name'...
- desktop_linux_manager_create_qube: unnamed test (unknown)
system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0
system_tests_qrexec
- TC_00_Qrexec_fedora-41-xfce: test_084_qrexec_service_argument_extra_env (error)
  subprocess.CalledProcessError: Command '/usr/lib/qubes/qrexec-clien...
system_tests_kde_gui_interactive
- clipboard_and_web: unnamed test (unknown)
- clipboard_and_web: Failed (test died)
  # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...
system_tests_misc
- TC_06_AppVM_debian-12-xfce: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b''b"stat: c...
- TC_06_AppVM_debian-12-xfce: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_debian-12-xfce: test_111_rescue_console_initrd (failure)
  AssertionError: Emergency mode not found
- TC_06_AppVM_fedora-41-xfce: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b''b"stat: c...
- TC_06_AppVM_fedora-41-xfce: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-gateway-17: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b' File: /h...
- TC_06_AppVM_whonix-gateway-17: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-gateway-17: test_111_rescue_console_initrd (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- TC_06_AppVM_whonix-workstation-17: test_020_custom_persist (failure)
  AssertionError: Too much / too little files persisted: b' File: /h...
- TC_06_AppVM_whonix-workstation-17: test_110_rescue_console (failure)
  AssertionError: Calling whoami failed, but emergency console started
- TC_06_AppVM_whonix-workstation-17: test_111_rescue_console_initrd (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_gui_tools
- desktop_linux_manager_config: unnamed test (unknown)
- desktop_linux_manager_config: Failed (test died)
  # Test died: no candidate needle with tag(s) 'qubes-global-config-t...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/127852#dependencies

29 fixed

system_tests_qrexec_perf@hw1
- TC_00_QrexecPerf_debian-12-xfce: test_110_simple_data_duplex (failure)
  AssertionError: '/usr/lib/qubes/tests/qrexec_perf.py --vm1=test-ins...
system_tests_storage_perf@hw1
- integ: storage_perf (error)
  ModuleNotFoundError: No module named 'qubes.tests.integ.storage_perf'
system_tests_suspend
- mount_and_boot_options: unnamed test (unknown)
- mount_and_boot_options: Failed (test died)
  # Test died: no candidate needle with tag(s) 'x11' matched...
system_tests_backup
- TC_10_BackupVM_whonix-gateway-17: test_110_send_to_vm_no_space (error)
  subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...
- TC_10_BackupVM_whonix-workstation-17: test_110_send_to_vm_no_space (error)
  subprocess.CalledProcessError: Command 'mknod /dev/loop0 b 7 0;trun...
system_tests_qrexec
- TC_00_Qrexec_debian-12-xfce: test_070_qrexec_vm_simultaneous_write (failure)
  exited with non-zero code 125; stderr: b"dd: error writing 'standa...
system_tests_dispvm
- TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
  AssertionError: './open-file test.txt' failed with ./open-file test...
system_tests_devices
- TC_00_List_whonix-gateway-17: test_000_list_loop (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_010_list_dm (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_011_list_dm_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_012_list_dm_delayed (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_013_list_dm_removed (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_020_list_loop_partition (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-gateway-17: test_021_list_loop_partition_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_000_list_loop (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_001_list_loop_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_010_list_dm (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_011_list_dm_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_012_list_dm_delayed (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_013_list_dm_removed (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_020_list_loop_partition (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_00_List_whonix-workstation-17: test_021_list_loop_partition_mounted (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_10_Attach_whonix-gateway-17: test_000_attach_reattach (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
- TC_10_Attach_whonix-workstation-17: test_000_attach_reattach (error)
  subprocess.CalledProcessError: Command 'set -e;truncate -s 128M /tm...
system_tests_audio
- TC_20_AudioVM_PipeWire_whonix-workstation-17: test_250_audio_playback_audiovm_pipewire (failure)
  AssertionError: pacat for test-inst-vm1 (xid 63) running(False) in ...
- TC_20_AudioVM_PipeWire_whonix-workstation-17: test_251_audio_playback_audiovm_pipewire_late_start (failure)
  AssertionError: too short audio, expected 10s, got 9.42956916099773...
system_tests_basic_vm_qrexec_gui_ext4
- switch_pool: Failed (test died)
  # Test died: command 'printf "label: gpt\n,,L" | sfdisk /dev/sdb' f...

Unstable tests

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

72 tests

debian-12-xfce_exec: 7.26
debian-12-xfce_exec-root: 27.20
debian-12-xfce_socket: 8.29
debian-12-xfce_socket-root: 8.38
debian-12-xfce_exec-data-simplex: 45.46
debian-12-xfce_exec-data-duplex: 48.27
debian-12-xfce_exec-data-duplex-root: 65.16
debian-12-xfce_socket-data-duplex: 79.93
fedora-41-xfce_exec: 9.17 🟢 ( previous job: 21.67, improvement: 42.33%)
fedora-41-xfce_exec-root: 60.36 🟢 ( previous job: 74.48, improvement: 81.04%)
fedora-41-xfce_socket: 8.97 🟢 ( previous job: 21.26, improvement: 42.18%)
fedora-41-xfce_socket-root: 8.55 🟢 ( previous job: 20.89, improvement: 40.95%)
fedora-41-xfce_exec-data-simplex: 48.83 🟢 ( previous job: 58.71, improvement: 83.17%)
fedora-41-xfce_exec-data-duplex: 49.41 🟢 ( previous job: 60.49, improvement: 81.68%)
fedora-41-xfce_exec-data-duplex-root: 83.73 🟢 ( previous job: 92.13, improvement: 90.89%)
fedora-41-xfce_socket-data-duplex: 78.88 🟢 ( previous job: 83.57, improvement: 94.39%)
whonix-gateway-17_exec: 7.52
whonix-gateway-17_exec-root: 37.55
whonix-gateway-17_socket: 7.73
whonix-gateway-17_socket-root: 7.64
whonix-gateway-17_exec-data-simplex: 46.03
whonix-gateway-17_exec-data-duplex: 46.90
whonix-gateway-17_exec-data-duplex-root: 70.52
whonix-gateway-17_socket-data-duplex: 83.04
whonix-workstation-17_exec: 8.25
whonix-workstation-17_exec-root: 52.70
whonix-workstation-17_socket: 8.53
whonix-workstation-17_socket-root: 8.14
whonix-workstation-17_exec-data-simplex: 46.39
whonix-workstation-17_exec-data-duplex: 48.34
whonix-workstation-17_exec-data-duplex-root: 78.38
whonix-workstation-17_socket-data-duplex: 83.34
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 481439.00
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 144485.00
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 413476.00
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 202236.00
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 89678.00
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5239.00
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10882.00
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1092.00
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 490906.00
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 136773.00
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 432759.00
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 201941.00
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 98972.00
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 5938.00
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7670.00
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3045.00
fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 350929.00
fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 269764.00
fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 294048.00
fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 65822.00
fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 87250.00
fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1585.00
fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8014.00
fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1099.00
fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 396137.00
fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 108284.00
fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 269349.00
fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 167192.00
fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 82037.00
fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 1915.00
fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8579.00
fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1637.00
fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 419598.00
fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 175595.00
fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 267289.00
fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 97143.00
fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 76431.00
fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3651.00
fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 9135.00
fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1252.00

Also red border for missing qube name resolves: QubesOS/qubes-issues#9768

alimirjamali · 2025-02-12T21:55:11Z

PipelineRetryFailed

marmarek added the openqa-pending label Feb 12, 2025

alimirjamali force-pushed the issue-9768 branch from a02e7f5 to 1fdc17d Compare February 12, 2025 07:36

alimirjamali force-pushed the issue-9768 branch from 1fdc17d to 2631e87 Compare February 12, 2025 17:48

Mark inactive "create" button as gray

96b9825

Also red border for missing qube name resolves: QubesOS/qubes-issues#9768

alimirjamali force-pushed the issue-9768 branch from 2631e87 to 96b9825 Compare February 12, 2025 20:03

marmarta approved these changes Feb 13, 2025

View reviewed changes

marmarek merged commit d437ced into QubesOS:main Feb 16, 2025
2 of 5 checks passed

qubesos-bot mentioned this pull request Feb 17, 2025

Improved Icons and UX #242

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Uh oh!

Mark inactive "create" button as gray #244

Mark inactive "create" button as gray #244

Uh oh!

alimirjamali commented Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

alimirjamali commented Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Mark inactive "create" button as gray #244

Mark inactive "create" button as gray #244

Uh oh!

Conversation

alimirjamali commented Feb 11, 2025

Uh oh!

codecov bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

alimirjamali commented Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 11, 2025 •

edited

Loading

qubesos-bot commented Feb 12, 2025 •

edited

Loading