Skip to content

Conversation

@jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 29, 2021

Description

One Line Summary

Update the androidx.work:work-runtime dependency range to account for OneSignal's minimum for the API's it is using and apps targeting Android 12.

Details

Motivation

Scope

This updates the version range dependency for androidx.work:work-runtime that will be consumed by apps. As well as the version OneSignal compiles with.

Testing

Unit testing

None, no logic change, existing tests will cover anything unexpected.

Manual testing

Tested Example app included in this repo with an Android 12 emulator. Test to ensure it registers and notifications open correctly.

Affected code checklist

Checked the known effected code that depends on the work-runtime library.

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Updated min version from 2.0.0 to 2.1.0 as we use
WorkManager.getInstance(Context) which was interduced in 2.1.0.
Updated to 2.7.99 as 2.7.0 is required if the app targets API level 31,
Android 12.
Copy link

@Andrewpk Andrewpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkasten2 jkasten2 requested review from a team, Jeasmine, emawby, nan-li and rgomezp November 1, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Targeting Android 12 is failing because OneSignal is using a WorkManager version < 2.7.0 Crash app but true setup

4 participants