Skip to content

Conversation

@asdacap
Copy link
Contributor

@asdacap asdacap commented Apr 18, 2023

  • After logging in RLP code, these show up.
The type is Nethermind.Serialization.Rlp.AccountDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Account]
The type is Nethermind.Serialization.Rlp.ByteStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Byte]
The type is Nethermind.Serialization.Rlp.ShortStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Int16]
The type is Nethermind.Serialization.Rlp.UShortStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt16]
The type is Nethermind.Serialization.Rlp.IntStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Int32]
The type is Nethermind.Serialization.Rlp.UIntStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt32]
The type is Nethermind.Serialization.Rlp.ULongStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt64]
The type is Nethermind.Serialization.Rlp.BlockDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Block]
The type is Nethermind.Serialization.Rlp.BlockInfoDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.BlockInfo]
The type is Nethermind.Serialization.Rlp.ChainLevelDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.ChainLevelInfo]
The type is Nethermind.Serialization.Rlp.CompactLogEntryDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.LogEntry]
The type is Nethermind.Serialization.Rlp.CompactReceiptStorageDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.TxReceipt]
The type is Nethermind.Serialization.Rlp.HeaderDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.BlockHeader]
The type is Nethermind.Serialization.Rlp.KeccakDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Crypto.Keccak]
The type is Nethermind.Serialization.Rlp.LogEntryDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.LogEntry]
The type is Nethermind.Serialization.Rlp.ReceiptMessageDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.TxReceipt]
The type is Nethermind.Serialization.Rlp.TxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Transaction]
The type is Nethermind.Serialization.Rlp.SystemTxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.SystemTransaction]
The type is Nethermind.Serialization.Rlp.GeneratedTxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.GeneratedTransaction]
The type is Nethermind.Serialization.Rlp.WithdrawalDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Withdrawal]
The type is Nethermind.Serialization.Rlp.Eip2930.AccessListDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Eip2930.AccessList]
The type is Nethermind.Network.NetworkNodeDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Config.NetworkNode]
  • The correct decoder is replaced later, but it could happen that this would randomly crash on other system.

After:

The type is Nethermind.Serialization.Rlp.AccountDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Account]
The type is Nethermind.Serialization.Rlp.ByteStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Byte]
The type is Nethermind.Serialization.Rlp.ShortStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Int16]
The type is Nethermind.Serialization.Rlp.UShortStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt16]
The type is Nethermind.Serialization.Rlp.IntStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.Int32]
The type is Nethermind.Serialization.Rlp.UIntStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt32]
The type is Nethermind.Serialization.Rlp.ULongStreamDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[System.UInt64]
The type is Nethermind.Serialization.Rlp.BlockDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Block]
The type is Nethermind.Serialization.Rlp.BlockInfoDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.BlockInfo]
The type is Nethermind.Serialization.Rlp.ChainLevelDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.ChainLevelInfo]
The type is Nethermind.Serialization.Rlp.HeaderDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.BlockHeader]
The type is Nethermind.Serialization.Rlp.KeccakDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Crypto.Keccak]
The type is Nethermind.Serialization.Rlp.LogEntryDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.LogEntry]
The type is Nethermind.Serialization.Rlp.ReceiptMessageDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.TxReceipt]
The type is Nethermind.Serialization.Rlp.TxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Transaction]
The type is Nethermind.Serialization.Rlp.SystemTxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.SystemTransaction]
The type is Nethermind.Serialization.Rlp.GeneratedTxDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.GeneratedTransaction]
The type is Nethermind.Serialization.Rlp.WithdrawalDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Withdrawal]
The type is Nethermind.Serialization.Rlp.Eip2930.AccessListDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Core.Eip2930.AccessList]
The type is Nethermind.Network.NetworkNodeDecoder Nethermind.Serialization.Rlp.IRlpDecoder`1[Nethermind.Config.NetworkNode]

Changes

  • Add an attribute to skip registration of compact receipt decoder.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@asdacap asdacap requested a review from MarekM25 April 18, 2023 13:39
@MarekM25 MarekM25 merged commit 8de80c2 into master Apr 18, 2023
@MarekM25 MarekM25 deleted the fix/make-sure-compact-receipt-not-registered-globally branch April 18, 2023 14:10
MarekM25 pushed a commit that referenced this pull request Apr 18, 2023
…ecoder. (#5586)

* Make sure compact receipt does not get registered as global receipt encoder

* Fix whitespace

(cherry picked from commit 8de80c2)
MarekM25 added a commit that referenced this pull request Apr 26, 2023
@MarekM25 MarekM25 mentioned this pull request Apr 26, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants