Make sure compact receipt does not get registered as global receipt decoder. (#5586)

* Make sure compact receipt does not get registered as global receipt encoder

* Fix whitespace

Author: asdacap

src/Nethermind/Nethermind.Core.Test/Encoding/ReceiptMessageDecoderTests.cs

@@ -0,0 +1,17 @@
+// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-License-Identifier: LGPL-3.0-only
+
+using Nethermind.Serialization.Rlp;
+using NUnit.Framework;
+
+namespace Nethermind.Core.Test.Encoding;
+
+public class ReceiptMessageDecoderTests
+{
+    [Test]
+    public void TestGlobalReceiptEncoderMustBeReceiptMessageDecoder()
+    {
+        Rlp.Decoders[typeof(TxReceipt)].Equals(typeof(ReceiptMessageDecoder));
+        Rlp.Decoders[typeof(LogEntry)].Equals(typeof(LogEntryDecoder));
+    }
+}

src/Nethermind/Nethermind.Serialization.Rlp/CompactLogEntryDecoder.cs

@@ -11,7 +11,8 @@
 
 namespace Nethermind.Serialization.Rlp
 {
-    public class CompactLogEntryDecoder
+    [Rlp.SkipGlobalRegistration]
+    public class CompactLogEntryDecoder : IRlpDecoder<LogEntry>
     {
         public static CompactLogEntryDecoder Instance { get; } = new();
 

src/Nethermind/Nethermind.Serialization.Rlp/CompactReceiptStorageDecoder.cs

@@ -12,6 +12,8 @@
 
 namespace Nethermind.Serialization.Rlp
 {
+
+    [Rlp.SkipGlobalRegistration]
     public class CompactReceiptStorageDecoder : IRlpStreamDecoder<TxReceipt>, IRlpValueDecoder<TxReceipt>, IRlpObjectDecoder<TxReceipt>
     {
         public static readonly CompactReceiptStorageDecoder Instance = new();

src/Nethermind/Nethermind.Serialization.Rlp/ReceiptArrayStorageDecoder.cs

@@ -7,6 +7,7 @@
 
 namespace Nethermind.Serialization.Rlp;
 
+[Rlp.SkipGlobalRegistration]
 public class ReceiptArrayStorageDecoder : IRlpStreamDecoder<TxReceipt[]>
 {
     public static readonly ReceiptArrayStorageDecoder Instance = new();

src/Nethermind/Nethermind.Serialization.Rlp/Rlp.cs

@@ -79,6 +79,11 @@ public static void RegisterDecoders(Assembly assembly)
                     continue;
                 }
 
+                if (type.GetCustomAttribute(typeof(SkipGlobalRegistration)) is not null)
+                {
+                    continue;
+                }
+
                 Type[]? implementedInterfaces = type.GetInterfaces();
                 foreach (Type? implementedInterface in implementedInterfaces)
                 {
@@ -1445,5 +1450,8 @@ public static int LengthOf(BlockInfo item)
             return rlpDecoder?.GetLength(item, RlpBehaviors.None) ?? throw new RlpException($"{nameof(Rlp)} does not support length of {nameof(BlockInfo)}");
         }
 
+        public class SkipGlobalRegistration : Attribute
+        {
+        }
     }
 }