Fix ledger apply script behavior on no filling actions&events #17612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
events/actions in generated zkapp commands.
…hen not specified
glyh
force-pushed
the
lyh/fix-ledger-test-apply-script-option
branch
from
09392a4 to
49d50a5
Compare
Member
Author
|
!ci-build-me |
Member
Author
|
This might break CI as there's another ledger apply script in buildkite. Will check this when I'm back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this script will always fill the acitons&events regardless of what is being passed in.
This is fixed by passing in the correct env var in
ledger test applyinvocation.