MIP Ref Impl: Increase events&actions limit #17573
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name would've been too long if I'm using the full "MIP Reference Implementation" here.
Status
Benchmark Data
Performance for Applying txn diff, reference PR: #16968
Commands ran:
./scripts/tests/ledger_test_apply.sh --transfer-parties-get-actions-eventsondevnetbuildledger_test_apply_bench.1024.events.json
bench.1024.events.out.txt
bench.1024.events.err.txt
The whole test took
11m46sto run.Commands ran:
./scripts/tests/ledger_test_apply.shwith #17612ledger_test_apply_bench.1024.no-events.json
bench.1024.no-events.out.txt
bench.1024.no-events.err.txt
The whole test took
1m57sto run.The last round of application, always create 200 txns with 1024 events & 1024 updates in first run, while 0 events & 0 updates in 2nd run. Via stdout, we know they take 8.2920899391174316s and 4.3161377906799316s, respectively.
I've rerun this benchmark also with limit set to 100:
Estimating pessimistically, say before HF nobody is using events/actions, but everyone use up to the 1000 limit after the HF. It's going to be a factor of$8.292 \div 2.930$ slow down, that's at most 3 times slow down. Here's the data for the 100 case:
ledger-test-apply-events-100.zip
ledger-test-apply-no-events-100.zip