Libsnark get_evaluation_domain works on macOS #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberian
reviewed
Jan 10, 2019
| #include <libff/common/double.hpp> | ||
| #include <libff/common/utils.hpp> | ||
|
|
||
| #include <execinfo.h> |
Contributor
|
|
Before this change on macOS systems, libsnark would crash on get_root_of_unity and exception handlers would not work. The hypothesis is that using exceptions for control flow in get_evaluation_domain triggers some sort of UB (probably because this runs statically before the main function). On Linux, the UB happens to work properly, but on OSX it doesn't. As such, I rewrote all the control-flow related exception handling in get_evaluation_domain to use an error bool pointer. I'll open a PR against libsnark directly when the review for this PR finishes.
bkase
force-pushed
the
libsnark-macos-support
branch
from
52fc59f to
5b8b806
Compare
Contributor
|
There are ways to avoid initializing those fields on exit paths, but the code is already there, and it's the FieldTs that are expensive anyway. I'm fine with it. Thank you for not letting uninitialized data escape. |
emberian
approved these changes
Jan 10, 2019
|
Dredging this back up as it's relevant again for me.
Yup, that's the problem. It's preventing two things in a different project:
It seems no pull requests are getting merged into libsnark, so will have to fork and apply this to my branch. |
MStumpp
pushed a commit
to BlockInfinity/libfqfft
that referenced
this pull request
Oct 27, 2021
MStumpp
pushed a commit
to BlockInfinity/libff
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change on macOS systems, libsnark would crash on
get_root_of_unity and exception handlers would not work. The
hypothesis is that using exceptions for control flow in
get_evaluation_domain triggers some sort of UB (probably because this
runs statically before the main function). On Linux, the UB happens to
work properly, but on OSX it doesn't. As such, I rewrote all the
control-flow related exception handling in get_evaluation_domain to use
an error bool pointer.
I'll open a PR against libsnark directly when the review for this PR
finishes.
On macOS the Coda build succeeds only after these changes are made (as
we use libsnark at compile time). CI will tell us that the build still
works on Linux.