Libsnark get_evaluation_domain works on macOS

Before this change on macOS systems, libsnark would crash on
get_root_of_unity and exception handlers would not work. The
hypothesis is that using exceptions for control flow in
get_evaluation_domain triggers some sort of UB (probably because this
runs statically before the main function). On Linux, the UB happens to
work properly, but on OSX it doesn't. As such, I rewrote all the
control-flow related exception handling in get_evaluation_domain to use
an error bool pointer.

I'll open a PR against libsnark directly when the review for this PR
finishes.

Author: bkase

src/lib/snarky/src/camlsnark_c/libsnark-caml/CMakeLists.txt

@@ -105,7 +105,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
   # Common compilation flags and warning configuration
   set(
     CMAKE_CXX_FLAGS
-    "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra -Wfatal-errors"
+    "${CMAKE_CXX_FLAGS} -std=c++14 -Wall -Wextra -Wfatal-errors"
   )
   if("${MULTICORE}")
       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp")

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/CMakeLists.txt

@@ -1,15 +1,19 @@
 add_subdirectory(gtest EXCLUDE_FROM_ALL)
 
+find_package(OpenSSL REQUIRED)
+
 if(${CURVE} STREQUAL "BN128")
   include_directories(ate-pairing/include)
   include_directories(xbyak)
+  include_directories(${OPENSSL_INCLUDE_DIR})
   add_library(
     zm
     STATIC
 
     ate-pairing/src/zm.cpp
     ate-pairing/src/zm2.cpp
   )
+  target_link_libraries(zm ${OPENSSL_LIBRARIES})
 endif()
 
 if("${WITH_SUPERCOP}")

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/gtest/.travis.yml

@@ -38,7 +38,7 @@ env:
   matrix:
     - GTEST_TARGET=googletest SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug   VERBOSE_MAKE=true VERBOSE
     - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug   VERBOSE_MAKE=true VERBOSE
-    - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug CXX_FLAGS=-std=c++11  VERBOSE_MAKE=true VERBOSE
+    - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug CXX_FLAGS=-std=c++14  VERBOSE_MAKE=true VERBOSE
 #    - GTEST_TARGET=googletest SHARED_LIB=ON  STATIC_LIB=ON CMAKE_PKG=ON  BUILD_TYPE=release VERBOSE_MAKE=false
 #    - GTEST_TARGET=googlemock SHARED_LIB=ON  STATIC_LIB=ON CMAKE_PKG=ON  BUILD_TYPE=release VERBOSE_MAKE=false
 notifications:

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libff/CMakeLists.txt

@@ -93,7 +93,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
   # Common compilation flags and warning configuration
   set(
     CMAKE_CXX_FLAGS
-    "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra -Wfatal-errors"
+    "${CMAKE_CXX_FLAGS} -std=c++14 -Wall -Wextra -Wfatal-errors"
   )
   if("${MULTICORE}")
       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp")

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libff/libff/algebra/fields/field_utils.hpp

@@ -18,11 +18,11 @@ namespace libff {
 // returns root of unity of order n (for n a power of 2), if one exists
 template<typename FieldT>
 typename std::enable_if<std::is_same<FieldT, Double>::value, FieldT>::type
-get_root_of_unity(const size_t n);
+get_root_of_unity(const size_t n, bool* err);
 
 template<typename FieldT>
 typename std::enable_if<!std::is_same<FieldT, Double>::value, FieldT>::type
-get_root_of_unity(const size_t n);
+get_root_of_unity(const size_t n, bool* err);
 
 template<typename FieldT>
 std::vector<FieldT> pack_int_vector_into_field_element_vector(const std::vector<size_t> &v, const size_t w);

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libff/libff/algebra/fields/field_utils.tcc

@@ -16,6 +16,11 @@
 #include <libff/common/double.hpp>
 #include <libff/common/utils.hpp>
 
+#include <execinfo.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+
 namespace libff {
 
 template<typename FieldT>
@@ -26,7 +31,7 @@ FieldT coset_shift()
 
 template<typename FieldT>
 typename std::enable_if<std::is_same<FieldT, Double>::value, FieldT>::type
-get_root_of_unity(const size_t n)
+get_root_of_unity(const size_t n, bool* err)
 {
     const double PI = 3.141592653589793238460264338328L;
 
@@ -39,11 +44,18 @@ get_root_of_unity(const size_t n)
 
 template<typename FieldT>
 typename std::enable_if<!std::is_same<FieldT, Double>::value, FieldT>::type
-get_root_of_unity(const size_t n)
+get_root_of_unity(const size_t n, bool* err)
 {
     const size_t logn = log2(n);
-    if (n != (1u << logn)) throw std::invalid_argument("libff::get_root_of_unity: expected n == (1u << logn)");
-    if (logn > FieldT::s) throw std::invalid_argument("libff::get_root_of_unity: expected logn <= FieldT::s");
+    if (n != (1u << logn)) {
+      *err = true;
+      return FieldT(1,1);
+    }
+
+    if (logn > FieldT::s) {
+      *err = true;
+      return FieldT(1,1);
+    }
 
     FieldT omega = FieldT::root_of_unity;
     for (size_t i = FieldT::s; i > logn; --i)

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/CMakeLists.txt

@@ -62,7 +62,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
   set(
     CMAKE_CXX_FLAGS
 
-    "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra -Wfatal-errors -pthread"
+    "${CMAKE_CXX_FLAGS} -std=c++14 -Wall -Wextra -Wfatal-errors -pthread"
   )
 
   if("${MULTICORE}")

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/depends/gtest/.travis.yml

@@ -38,7 +38,7 @@ env:
   matrix:
     - GTEST_TARGET=googletest SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug   VERBOSE_MAKE=true VERBOSE
     - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug   VERBOSE_MAKE=true VERBOSE
-    - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug CXX_FLAGS=-std=c++11  VERBOSE_MAKE=true VERBOSE
+    - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug CXX_FLAGS=-std=c++14  VERBOSE_MAKE=true VERBOSE
 #    - GTEST_TARGET=googletest SHARED_LIB=ON  STATIC_LIB=ON CMAKE_PKG=ON  BUILD_TYPE=release VERBOSE_MAKE=false
 #    - GTEST_TARGET=googlemock SHARED_LIB=ON  STATIC_LIB=ON CMAKE_PKG=ON  BUILD_TYPE=release VERBOSE_MAKE=false
 notifications:

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/depends/libff/CMakeLists.txt

@@ -93,7 +93,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
   # Common compilation flags and warning configuration
   set(
     CMAKE_CXX_FLAGS
-    "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wextra -Wfatal-errors"
+    "${CMAKE_CXX_FLAGS} -std=c++14 -Wall -Wextra -Wfatal-errors"
   )
   if("${MULTICORE}")
       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp")

src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/arithmetic_sequence_domain.hpp

@@ -28,7 +28,7 @@ namespace libfqfft {
     FieldT arithmetic_generator;
     void do_precomputation();
 
-    arithmetic_sequence_domain(const size_t m);
+    arithmetic_sequence_domain(const size_t m, bool* err);
 
     void FFT(std::vector<FieldT> &a);
     void iFFT(std::vector<FieldT> &a);
@@ -46,4 +46,4 @@ namespace libfqfft {
 
 #include <libfqfft/evaluation_domain/domains/arithmetic_sequence_domain.tcc>
 
-#endif // ARITHMETIC_SEQUENCE_DOMAIN_HPP
+#endif // ARITHMETIC_SEQUENCE_DOMAIN_HPP