Skip to content

Conversation

@ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 11, 2021

  • Enforcing minimum node version 12 via circleci, .nvmrc, and the package file
  • Adding basic .gitattributes file
  • Adding basic .editorconfig file
  • Updating .gitignore file

Related: https://github.com/MetaMask/MetaMask-planning/issues/32

@ryanml ryanml self-assigned this Apr 11, 2021
@ryanml ryanml requested a review from a team April 11, 2021 05:44
@ryanml
Copy link
Contributor Author

ryanml commented Apr 11, 2021

Note, strange .nvmrc diff is due to strange chars in the current file: https://github.com/MetaMask/object-multiplex/blob/main/.nvmrc#L1

* Enforcing minimum node version 12 via circleci, .nvmrc, and the package file
* Adding basic .gitattributes file
* Adding basic .editorconfig file
* Updating .gitignore file

* Adding CODEOWNERS file
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanml ryanml merged commit 149045d into main Apr 13, 2021
@ryanml ryanml deleted the repo-standard branch April 13, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants