Skip to content

Commit 149045d

Browse files
authored
Repo standardization (#16)
* Enforcing minimum node version 12 via circleci, .nvmrc, and the package file * Adding basic .gitattributes file * Adding basic .editorconfig file * Updating .gitignore file * Adding CODEOWNERS file
1 parent e590d95 commit 149045d

File tree

7 files changed

+29
-4
lines changed

7 files changed

+29
-4
lines changed

.circleci/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ workflows:
1818
jobs:
1919
prep-deps:
2020
docker:
21-
- image: circleci/node:10
21+
- image: circleci/node:12
2222
steps:
2323
- checkout
2424
- run:
@@ -37,7 +37,7 @@ jobs:
3737

3838
test-lint:
3939
docker:
40-
- image: circleci/node:10
40+
- image: circleci/node:12
4141
steps:
4242
- checkout
4343
- attach_workspace:
@@ -48,7 +48,7 @@ jobs:
4848

4949
test-build-unit:
5050
docker:
51-
- image: circleci/node:10
51+
- image: circleci/node:12
5252
steps:
5353
- checkout
5454
- attach_workspace:
@@ -59,7 +59,7 @@ jobs:
5959

6060
all-tests-pass:
6161
docker:
62-
- image: circleci/node:10
62+
- image: circleci/node:12
6363
steps:
6464
- run:
6565
name: All tests passed

.editorconfig

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
root = true
2+
3+
[*]
4+
indent_style = space
5+
indent_size = 2
6+
end_of_line = lf
7+
charset = utf-8
8+
trim_trailing_whitespace = true
9+
insert_final_newline = true

.gitattributes

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
* text=auto
2+
3+
yarn.lock linguist-generated=false

.github/CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Lines starting with '#' are comments.
2+
# Each line is a file pattern followed by one or more owners.
3+
4+
* @MetaMask/devs

.nvmrc

-8 Bytes
Binary file not shown.

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,9 @@ streamA.write(123)
2222
// or pipe together normally
2323
streamB.pipe(evilAiBrain).pipe(streamB)
2424
```
25+
26+
## Running tests
27+
28+
```bash
29+
yarn test
30+
```

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"version": "1.1.0",
44
"description": "Simple stream multiplexing for objectMode.",
55
"main": "dist/index.js",
6+
"engines": {
7+
"node": ">=12.0.0"
8+
},
69
"files": [
710
"dist/"
811
],

0 commit comments

Comments
 (0)