feat: add http.peer_ip to the root span
#143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`realip_remote_addr` can be spoofed without using proxy or not configuring it properly. `peer_addr` is considered more trustworthy for security-sensitive operations, which is the actual socket address of the client when not behind any proxy, and the proxy's address otherwise. When we are using a trusted and properly configured proxy, `peer_addr` should return the proxy's address, and `realip_remote_addr` should return a trusted client address.
|
@zefr0x read this: #106 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realip_remote_addrcan be spoofed without using proxy or not configuring it properly.peer_addris considered more trustworthy for security-sensitive operations, which is the actual socket address of the client when not behind any proxy, and the proxy's address otherwise.When we are using a trusted and properly configured proxy,
peer_addrshould return the proxy's address, andrealip_remote_addrshould return a trusted client address.Read:
https://docs.rs/actix-web/4.11.0/actix_web/dev/struct.ConnectionInfo.html#security