Skip to content

Conversation

@omid
Copy link
Contributor

@omid omid commented May 24, 2023

Add http referer to the fields

@LukeMathWalker
Copy link
Owner

This is not part of OpenTelemetry's HTTP semantic conventions.
The proper field name should be http.request.header.referer, but I don't see a reason to add it among the default fields.

@omid
Copy link
Contributor Author

omid commented Aug 27, 2023

@LukeMathWalker, Is there a specfic way to add custom fields next to the default fields?

@LukeMathWalker
Copy link
Owner

Yes, via root_span!

@omid
Copy link
Contributor Author

omid commented Aug 29, 2023

@LukeMathWalker thanks. It helped a lot. I was not aware of the convention.

Out of curiosity, why user_agent.original, based on otel semantic conventions, named http.user_agent in the library?
Or http.response.status_code named simply http.status_code?

@LukeMathWalker
Copy link
Owner

Historical mistakes we now have to live with—changing the field names now would be quite dangerous (e.g. folks are probably relying on them for alerts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants