-
Notifications
You must be signed in to change notification settings - Fork 604
doc: add gateway API features in KIC 2.4 #4231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pmalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if that will work together with #4230 🤔
|
Wanted to make some discussions on introducing supported gateway API features:
|
To me this should be somewhere near the top of a docs page. Haven't made my mind yet about which one (of As of source code for docs being messy: oh well, it's not going to be the end of the world. We'll just add/remove particular features/limitations to/from particular versions' lists. |
ec4192b to
8a716d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rainest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put currently supported gateway API resources, and add a link to a page in reference part introducing supported features of each resource.
I like this option. There's not much reason the existing limitations section went into the guide other than that the guide was the only article. A reference page sounds like a good home for a by-type list of things we do or do not support.
For the most part, our reference should omit core features that we support: any core feature not otherwise mentioned is assumed supported. We'd list only:
- Extended features that we do support.
- Core features that we do not support.
So roughly, the page would be a section for each type with Extended feature support and Limitations sections, with the existing Limitations section in the guide removed and broken into the the individual type subsections.
The if template syntax can get a bit messy, but it's what we've got.
Since that reference is a new page, we wouldn't need to worry about conflicts with #4230
8a716d3 to
30ef54d
Compare
pmalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that in order to fix (or rather ignore) these spelling errors, you can add exceptions to https://github.com/Kong/docs.konghq.com/blob/main/.github/styles/kong/dictionary.txt
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
src/kubernetes-ingress-controller/references/gateway-api-support.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Patryk Małek <[email protected]>
Summary
Add introduction of gateway API features of KIC for version 2.4 and later.
Reason
fixes #4026.
Testing