doc(kic) add Gateway API concepts #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
added
review:tech
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rainest
force-pushed
the
doc/gateway-concepts
branch
from
fde46f9 to
d267cf7
Compare
randmonkey
reviewed
Aug 12, 2022
randmonkey
requested changes
Aug 12, 2022
pmalek
reviewed
Aug 12, 2022
Contributor
|
Is this ready to be reviewed? |
rainest
force-pushed
the
doc/gateway-concepts
branch
from
17aa36f to
baac9fc
Compare
Contributor
Author
|
@Guaris should be. We may get a few more comments from the rest of the Kubernetes team on tech stuff, but those hopefully don't result in huge changes. Not urgent, so if you want to wait a few days for any of those to trickle in before giving it a final pass that's fine. |
randmonkey
reviewed
Aug 15, 2022
randmonkey
reviewed
Aug 15, 2022
Contributor
randmonkey
left a comment
randmonkey
left a comment
There was a problem hiding this comment.
LGTM here, so removed my change requests. But did not directly approve, to wait for others' reviews.
rainest
force-pushed
the
doc/gateway-concepts
branch
from
baac9fc to
15efc5f
Compare
shaneutt
approved these changes
Aug 15, 2022
randmonkey
approved these changes
Aug 16, 2022
pmalek
reviewed
Aug 16, 2022
pmalek
requested changes
Aug 16, 2022
Member
pmalek
left a comment
pmalek
left a comment
There was a problem hiding this comment.
blocking to get the whitespaces resolved
rainest
force-pushed
the
doc/gateway-concepts
branch
from
15efc5f to
4ea02eb
Compare
pmalek
approved these changes
Aug 16, 2022
Guaris
requested changes
Aug 22, 2022
Guaris
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Gateway API page under the KIC Concepts section. This covers two alpha limitations where Kong's implementation differs from a hypothetical standard Gateway API implementation:
Update the Gateway API guide with links to the new concepts page.
Update the Gateway API guide to include an example of a user-provided certificate.
Reason
Fix #4054
Fix #4229
Testing
Awaiting preview.