remove nearly all remaining deprecations #28486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REPLCompletions allows tab-completion to show the possible signatures of a given function when in the midst of writing its arguments. It uses inference to determine the possible types of the already-written arguments, subsetting the possible signatures. With the removal of `.op` as a function, it is no longer able to infer these types and thus no longer subsets the signatures as previously expected. The failure mode is very graceful here -- it just assumes `Any` and shows more signatures. This can be re-implemented later
alyst
pushed a commit
to alyst/julia
that referenced
this pull request
Aug 9, 2018
* Fix at-inferred with a single dot-broadcast op * Mark .op type-inference-based completion of method signatures as broken REPLCompletions allows tab-completion to show the possible signatures of a given function when in the midst of writing its arguments. It uses inference to determine the possible types of the already-written arguments, subsetting the possible signatures. With the removal of `.op` as a function, it is no longer able to infer these types and thus no longer subsets the signatures as previously expected. The failure mode is very graceful here -- it just assumes `Any` and shows more signatures. This can be re-implemented later
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* Fix at-inferred with a single dot-broadcast op * Mark .op type-inference-based completion of method signatures as broken REPLCompletions allows tab-completion to show the possible signatures of a given function when in the midst of writing its arguments. It uses inference to determine the possible types of the already-written arguments, subsetting the possible signatures. With the removal of `.op` as a function, it is no longer able to infer these types and thus no longer subsets the signatures as previously expected. The failure mode is very graceful here -- it just assumes `Any` and shows more signatures. This can be re-implemented later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.