Skip to content

Conversation

@nothiaki
Copy link

@nothiaki nothiaki commented Jul 7, 2025

Closes #13486

focus to link field when open LinkedFileEditDialog

2025-07-07_14-04

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot
Copy link

trag-bot bot commented Jul 7, 2025

@trag-bot didn't find any issues in the code! ✅✨

fileType.valueProperty().bindBidirectional(viewModel.selectedExternalFileTypeProperty());
sourceUrl.textProperty().bindBidirectional(viewModel.sourceUrlProperty());

Platform.runLater(() -> link.requestFocus());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calixtus This is differrent than the stack overflow solution from https://stackoverflow.com/a/70021819/873282 - is it also OK?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevCall: @nothiaki Please follow https://stackoverflow.com/a/70021819/873282 if you can.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason: lifecycle could be "problematic" - there is no guarantee that intializate is called right before showing the dialog.

@jabref-machine
Copy link
Collaborator

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it.

In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push.

@koppor
Copy link
Member

koppor commented Jul 9, 2025

Other contributor works in this now.

@koppor
Copy link
Member

koppor commented Jul 10, 2025

The reason for the double work is that @nothiaki did not follow our contributing guide to get a task assigned: https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md#getting-a-task-assigned

@koppor koppor mentioned this pull request Jul 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog "Add file link" should focus field "Link" when opening

3 participants