Fix constructing labelSelector and test label strings #4221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejal29
requested review from
balopat,
briandealwis,
dgageot and
nkubala
as code owners
tejal29
force-pushed
the
fix_label_selector
branch
from
836b339 to
6f89a83
Compare
Codecov Report
|
tejal29
force-pushed
the
fix_label_selector
branch
from
6f89a83 to
3fa277f
Compare
7 tasks
briandealwis
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4219 i added support for multiple labels to query.
However, the way i was constructing the
listOptions, ended up settingjsonrepresentation of theLabelSelectorinstead of actual label query.e.g
kubectl get pods -l key1=value1, key2=value2After reading this documentation/usage issue, https://github.com/kubernetes/apimachinery/issues/47 i realized there is
"k8s.io/apimachinery/pkg/labelspackage that has helpers methods to convert a key value pair to correct string format.Tests not test the label query string.