Small diag improvements
#4219
Merged
Small diag improvements
#4219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labels for validation
tejal29
requested review from
balopat,
briandealwis,
dgageot and
nkubala
as code owners
dgageot
approved these changes
May 19, 2020
This was referenced May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
diag.Runto pass in context so it can be cancelled if parent context get cancelled or is passed incontext.WithTimeoutchild context.diag.Runto query multiple labels. This would be useful in skaffold to query pods within a deployment in a particular skaffold session.User facing changes (remove if N/A)
No.
Follow-up Work (remove if N/A)