-
Notifications
You must be signed in to change notification settings - Fork 3
feat: header with link #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation
} | ||
} | ||
}, | ||
const { breakpoints } = createTheme() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一度breakpointsを拾ってくるために宣言して、再度typographyをカスタムしたテーマをcreateThemeで宣言する
この方式でないとtypographyからいくつかのプロパティが抜け落ち、MaterialIconの利用ができなくなった
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装ありがとうございます!いくつかコメントしたのでご確認お願いします 🙇
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
Co-authored-by: Taiga KIYOKAWA <[email protected]>
@taigakiyokawa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆 ありがとうございます!
* [fix] Fix date for closing application from Sat to Tue (#65) * feat: add GitHub template (#68) * fix: template (#69) * fix: file structure (#70) * merge main into develop (#72) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * Merge main into develop (#169) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation * feat: add information about CfP result (#165) --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * feat: useSessionize (#171) * feat: useSettionize * add EOL * スポンサー(パートナー)ページの実装 (#170) * feat: partner page * SAMPLE json / images * fix: `desc` to `description` * fix: simplify prop type name * fix: `desc` to `description` * fix: extract params from context * feat: header with link (#172) * chore: Remove CommunityBoothSection from PageTop (#174) * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize (#173) * chore: Remove `next/link` temporary for forwarding to HTML pages build by Sessionize * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize * fix(HeaderMenu): Use `next/link` when href is `/` * Proposal feat: hide home label from header (#175) * feat: hide home label from header * fix header menu * comment out unused import --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> Co-authored-by: sivchari <[email protected]> Co-authored-by: Shinji Nakamatsu <[email protected]>
* [fix] Fix date for closing application from Sat to Tue (#65) * feat: add GitHub template (#68) * fix: template (#69) * fix: file structure (#70) * merge main into develop (#72) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * Merge main into develop (#169) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation * feat: add information about CfP result (#165) --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * feat: useSessionize (#171) * feat: useSettionize * add EOL * スポンサー(パートナー)ページの実装 (#170) * feat: partner page * SAMPLE json / images * fix: `desc` to `description` * fix: simplify prop type name * fix: `desc` to `description` * fix: extract params from context * feat: header with link (#172) * chore: Remove CommunityBoothSection from PageTop (#174) * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize (#173) * chore: Remove `next/link` temporary for forwarding to HTML pages build by Sessionize * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize * fix(HeaderMenu): Use `next/link` when href is `/` * Proposal feat: hide home label from header (#175) * feat: hide home label from header * fix header menu * comment out unused import * fix: remove community booth section (#177) * feat: community booth section (#67) * fix: remove community booth section * chore: add eslint rule (#178) * feat: community booth section (#67) * fix: remove community booth section * chore: add eslint rules --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> Co-authored-by: sivchari <[email protected]> Co-authored-by: Shinji Nakamatsu <[email protected]>
* [fix] Fix date for closing application from Sat to Tue (#65) * feat: add GitHub template (#68) * fix: template (#69) * fix: file structure (#70) * merge main into develop (#72) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * Merge main into develop (#169) * [fix] Fix date for closing application from Sat to Tue (#65) (#66) * feat: community booth section (#67) * feat: specified commercial transaction (#71) * feat: specified commercial transaction * fix typo * fix: i18n locale * fix: english explanation * feat: add information about CfP result (#165) --------- Co-authored-by: Taiga KIYOKAWA <[email protected]> * feat: useSessionize (#171) * feat: useSettionize * add EOL * スポンサー(パートナー)ページの実装 (#170) * feat: partner page * SAMPLE json / images * fix: `desc` to `description` * fix: simplify prop type name * fix: `desc` to `description` * fix: extract params from context * feat: header with link (#172) * chore: Remove CommunityBoothSection from PageTop (#174) * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize (#173) * chore: Remove `next/link` temporary for forwarding to HTML pages build by Sessionize * chore: Temporarily change links of Header to the links to HTML pages build by Sessionize * fix(HeaderMenu): Use `next/link` when href is `/` * Proposal feat: hide home label from header (#175) * feat: hide home label from header * fix header menu * comment out unused import * fix: remove community booth section (#177) * feat: community booth section (#67) * fix: remove community booth section * chore: add eslint rule (#178) * feat: community booth section (#67) * fix: remove community booth section * chore: add eslint rules * chore: Close sponsors application (#180) * chore: Remove the button for application to sponsors due to be already closed * chore: Fix arrangement of Gophers due to remove the button * chore: Change description to "Sponsors application has been closed.~" --------- Co-authored-by: sivchari <[email protected]> Co-authored-by: maito1201 <[email protected]> Co-authored-by: Shinji Nakamatsu <[email protected]>
ヘッダーに画面遷移を実装
PC

SP
