NPI-3438 Restructure clock comparison and sisre functions for consistent arg order #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument order consistent. Includes various type hints and other fixes
seballgeyer
approved these changes
May 4, 2025
Collaborator
seballgeyer
left a comment
seballgeyer
left a comment
There was a problem hiding this comment.
the PR successfully swaps the arguments for the compare_clk function via the introduction of a new diff_clk function and updates the codebase accordingly. This achieves the stated objective while maintaining backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**This PR may be a duplicate of: #77 **
This PR reorganises and cleans up some of the clock comparison and sisre calculation code, to improve consistency.
Originally prompted by #19
Previous work addressed in: #23
This PR also includes various type hints and other fixes.