Skip to content

fix: use cached config if identify user fails #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

fix: use cached config if identify user fails #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions android-client-sdk/src/main/java/com/devcycle/sdk/android/api/DevCycleClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,7 @@ class DevCycleClient private constructor(
private val variableInstanceMap: MutableMap<String, MutableMap<Any, WeakReference<Variable<*>>>> = mutableMapOf()

init {
val cachedConfig = if (disableConfigCache) null else dvcSharedPrefs.getConfig(user)
if (cachedConfig != null) {
config = cachedConfig
isConfigCached.set(true)
DevCycleLogger.d("Loaded config from cache")
observable.configUpdated(config)
}
useCachedConfigForUser(user)

initializeJob = coroutineScope.async(coroutineContext) {
isExecuting.set(true)
Expand Down Expand Up @@ -232,6 +226,10 @@ class DevCycleClient private constructor(
fetchConfig(updatedUser)
config?.variables?.let { callback?.onSuccess(it) }
} catch (t: Throwable) {
DevCycleLogger.d("Error fetching config for user_id %s", updatedUser.userId)
// In the event that the config request fails (i.e. the device is offline)
// Fallback to using a Cached Configuration for the User if available
useCachedConfigForUser(updatedUser)
Copy link
Contributor

@jsalaber jsalaber Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a debug log above it too, makes it clearer that it's using the cached config because of the config failing

callback?.onError(t)
} finally {
handleQueuedConfigRequests()
Expand Down Expand Up @@ -555,6 +553,16 @@ class DevCycleClient private constructor(
}
}

private fun useCachedConfigForUser(user: PopulatedUser) {
val cachedConfig = if (disableConfigCache) null else dvcSharedPrefs.getConfig(user)
if (cachedConfig != null) {
config = cachedConfig
isConfigCached.set(true)
DevCycleLogger.d("Loaded config from cache for user_id %s", user.userId)
observable.configUpdated(config)
}
}

class DevCycleClientBuilder {
private var context: Context? = null
private var customLifecycleHandler: Handler? = null
Expand Down