fix: use cached config if identify user fails #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaushalkapasi
commented
Jun 9, 2025
kaushalkapasi
commented
- fix: use a cached config (if available), if identify user request fails
jsalaber
reviewed
Jun 9, 2025
| } catch (t: Throwable) { | ||
| // In the event that the config request fails (i.e. the device is offline) | ||
| // Fallback to using a Cached Configuration for the User if available | ||
| useCachedConfigForUser(updatedUser) |
There was a problem hiding this comment.
maybe add a debug log above it too, makes it clearer that it's using the cached config because of the config failing
… fails for any reason
kaushalkapasi
force-pushed
the
fix-use-cached-config-on-identify-failure
branch
from
f7edac2 to
1f9849f
Compare
jonathannorris
approved these changes
Jun 9, 2025
jsalaber
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.