Skip to content

disable telemetry for MethodHandle lookups #8160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

disable telemetry for MethodHandle lookups #8160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...strap/src/main/java/datadog/trace/bootstrap/debugger/el/ReflectiveFieldValueResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package datadog.trace.bootstrap.debugger.el;

import static datadog.trace.api.telemetry.LogCollector.EXCLUDE_TELEMETRY;
import static java.lang.invoke.MethodType.methodType;

import datadog.trace.bootstrap.debugger.CapturedContext;
Expand All @@ -22,7 +23,7 @@ public class ReflectiveFieldValueResolver {
MethodHandles.Lookup lookup = MethodHandles.lookup();
methodHandle = lookup.findVirtual(Field.class, "trySetAccessible", methodType(boolean.class));
} catch (Exception e) {
LOGGER.debug("Looking up trySetAccessible failed: ", e);
LOGGER.debug(EXCLUDE_TELEMETRY, "Looking up trySetAccessible failed: ", e);
}
TRY_SET_ACCESSIBLE = methodHandle;
}
Expand All @@ -35,7 +36,7 @@ public class ReflectiveFieldValueResolver {
try {
field = ReflectiveFieldValueResolver.class.getDeclaredField("INACCESSIBLE_FIELD");
} catch (Exception e) {
LOGGER.debug("INACCESSIBLE_FIELD failed: ", e);
LOGGER.debug(EXCLUDE_TELEMETRY, "INACCESSIBLE_FIELD failed: ", e);
}
INACCESSIBLE_FIELD = field;
}
Expand All @@ -51,7 +52,7 @@ public class ReflectiveFieldValueResolver {
MethodHandles.Lookup lookup = MethodHandles.lookup();
methodHandle = lookup.findVirtual(Class.class, "getModule", methodType(moduleClass));
} catch (Exception e) {
LOGGER.debug("Looking up getModule failed: ", e);
LOGGER.debug(EXCLUDE_TELEMETRY, "Looking up getModule failed: ", e);
}
GET_MODULE = methodHandle;
MODULE_CLASS = moduleClass;
Expand Down
Loading