-
Notifications
You must be signed in to change notification settings - Fork 316
disable telemetry for MethodHandle lookups #8160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can happen frequently (every startup on jdk8)
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (320.609 µs) : 266, 375
. : milestone, 321,
basic (311.241 µs) : 299, 323
. : milestone, 311,
loop (10.431 ms) : 10380, 10481
. : milestone, 10431,
section candidate
noprobe (314.527 µs) : 273, 356
. : milestone, 315,
basic (311.766 µs) : 302, 321
. : milestone, 312,
loop (10.391 ms) : 10357, 10426
. : milestone, 10391,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056271
Total [baseline] (10.508 s) : 0, 10508343
Agent [candidate] (1.055 s) : 0, 1055321
Total [candidate] (10.423 s) : 0, 10422806
section appsec
Agent [baseline] (1.189 s) : 0, 1189063
Total [baseline] (10.728 s) : 0, 10727573
Agent [candidate] (1.191 s) : 0, 1191165
Total [candidate] (10.704 s) : 0, 10704033
section iast
Agent [baseline] (1.179 s) : 0, 1179024
Total [baseline] (10.96 s) : 0, 10960224
Agent [candidate] (1.183 s) : 0, 1182934
Total [candidate] (10.939 s) : 0, 10938504
section profiling
Agent [baseline] (1.276 s) : 0, 1275662
Total [baseline] (10.839 s) : 0, 10839070
Agent [candidate] (1.286 s) : 0, 1286055
Total [candidate] (10.829 s) : 0, 10829026
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.515 ms) : 0, 713515
BytebuddyAgent [candidate] (714.649 ms) : 0, 714649
GlobalTracer [baseline] (255.905 ms) : 0, 255905
GlobalTracer [candidate] (256.141 ms) : 0, 256141
AppSec [baseline] (55.369 ms) : 0, 55369
AppSec [candidate] (55.093 ms) : 0, 55093
Remote Config [baseline] (735.176 µs) : 0, 735
Remote Config [candidate] (719.225 µs) : 0, 719
Telemetry [baseline] (15.703 ms) : 0, 15703
Telemetry [candidate] (13.629 ms) : 0, 13629
section appsec
BytebuddyAgent [baseline] (730.775 ms) : 0, 730775
BytebuddyAgent [candidate] (733.156 ms) : 0, 733156
GlobalTracer [baseline] (253.711 ms) : 0, 253711
GlobalTracer [candidate] (254.108 ms) : 0, 254108
AppSec [baseline] (171.275 ms) : 0, 171275
AppSec [candidate] (170.136 ms) : 0, 170136
IAST [baseline] (19.449 ms) : 0, 19449
IAST [candidate] (20.09 ms) : 0, 20090
Remote Config [baseline] (668.186 µs) : 0, 668
Remote Config [candidate] (669.586 µs) : 0, 670
Telemetry [baseline] (7.966 ms) : 0, 7966
Telemetry [candidate] (7.951 ms) : 0, 7951
section iast
BytebuddyAgent [baseline] (828.8 ms) : 0, 828800
BytebuddyAgent [candidate] (831.807 ms) : 0, 831807
GlobalTracer [baseline] (246.631 ms) : 0, 246631
GlobalTracer [candidate] (247.443 ms) : 0, 247443
AppSec [baseline] (58.316 ms) : 0, 58316
AppSec [candidate] (57.848 ms) : 0, 57848
IAST [baseline] (21.173 ms) : 0, 21173
IAST [candidate] (21.593 ms) : 0, 21593
Remote Config [baseline] (662.11 µs) : 0, 662
Remote Config [candidate] (651.575 µs) : 0, 652
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.502 ms) : 0, 8502
section profiling
BytebuddyAgent [baseline] (702.67 ms) : 0, 702670
BytebuddyAgent [candidate] (709.727 ms) : 0, 709727
GlobalTracer [baseline] (372.326 ms) : 0, 372326
GlobalTracer [candidate] (375.831 ms) : 0, 375831
AppSec [baseline] (54.771 ms) : 0, 54771
AppSec [candidate] (53.903 ms) : 0, 53903
Remote Config [baseline] (653.374 µs) : 0, 653
Remote Config [candidate] (655.241 µs) : 0, 655
Telemetry [baseline] (7.809 ms) : 0, 7809
Telemetry [candidate] (7.8 ms) : 0, 7800
ProfilingAgent [baseline] (95.599 ms) : 0, 95599
ProfilingAgent [candidate] (95.915 ms) : 0, 95915
Profiling [baseline] (95.623 ms) : 0, 95623
Profiling [candidate] (95.939 ms) : 0, 95939
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054352
Total [baseline] (8.609 s) : 0, 8608502
Agent [candidate] (1.056 s) : 0, 1055827
Total [candidate] (8.641 s) : 0, 8640510
section iast
Agent [baseline] (1.195 s) : 0, 1194671
Total [baseline] (9.226 s) : 0, 9225951
Agent [candidate] (1.183 s) : 0, 1182541
Total [candidate] (9.251 s) : 0, 9251330
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182411
Total [baseline] (9.185 s) : 0, 9185106
Agent [candidate] (1.18 s) : 0, 1179942
Total [candidate] (9.179 s) : 0, 9179212
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174831
Total [baseline] (9.223 s) : 0, 9222887
Agent [candidate] (1.179 s) : 0, 1178784
Total [candidate] (9.179 s) : 0, 9179436
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.597 ms) : 0, 713597
BytebuddyAgent [candidate] (714.048 ms) : 0, 714048
GlobalTracer [baseline] (255.506 ms) : 0, 255506
GlobalTracer [candidate] (256.484 ms) : 0, 256484
AppSec [baseline] (55.978 ms) : 0, 55978
AppSec [candidate] (55.273 ms) : 0, 55273
Remote Config [baseline] (725.125 µs) : 0, 725
Remote Config [candidate] (727.023 µs) : 0, 727
Telemetry [baseline] (13.527 ms) : 0, 13527
Telemetry [candidate] (14.209 ms) : 0, 14209
section iast
BytebuddyAgent [baseline] (841.46 ms) : 0, 841460
BytebuddyAgent [candidate] (831.457 ms) : 0, 831457
GlobalTracer [baseline] (248.877 ms) : 0, 248877
GlobalTracer [candidate] (247.155 ms) : 0, 247155
AppSec [baseline] (58.292 ms) : 0, 58292
AppSec [candidate] (58.176 ms) : 0, 58176
IAST [baseline] (21.574 ms) : 0, 21574
IAST [candidate] (21.454 ms) : 0, 21454
Remote Config [baseline] (667.415 µs) : 0, 667
Remote Config [candidate] (662.014 µs) : 0, 662
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.567 ms) : 0, 8567
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.433 ms) : 0, 831433
BytebuddyAgent [candidate] (829.413 ms) : 0, 829413
GlobalTracer [baseline] (246.904 ms) : 0, 246904
GlobalTracer [candidate] (246.869 ms) : 0, 246869
AppSec [baseline] (58.342 ms) : 0, 58342
AppSec [candidate] (58.095 ms) : 0, 58095
IAST [baseline] (21.526 ms) : 0, 21526
IAST [candidate] (21.364 ms) : 0, 21364
Remote Config [baseline] (663.978 µs) : 0, 664
Remote Config [candidate] (672.445 µs) : 0, 672
Telemetry [baseline] (8.494 ms) : 0, 8494
Telemetry [candidate] (8.532 ms) : 0, 8532
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (826.24 ms) : 0, 826240
BytebuddyAgent [candidate] (828.465 ms) : 0, 828465
GlobalTracer [baseline] (246.409 ms) : 0, 246409
GlobalTracer [candidate] (246.913 ms) : 0, 246913
AppSec [baseline] (57.563 ms) : 0, 57563
AppSec [candidate] (58.42 ms) : 0, 58420
IAST [baseline] (20.597 ms) : 0, 20597
IAST [candidate] (20.76 ms) : 0, 20760
Remote Config [baseline] (646.767 µs) : 0, 647
Remote Config [candidate] (649.73 µs) : 0, 650
Telemetry [baseline] (8.364 ms) : 0, 8364
Telemetry [candidate] (8.459 ms) : 0, 8459
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section baseline
no_agent (385.654 µs) : 366, 405
. : milestone, 386,
iast (506.131 µs) : 484, 528
. : milestone, 506,
iast_FULL (658.687 µs) : 637, 680
. : milestone, 659,
iast_GLOBAL (531.966 µs) : 510, 554
. : milestone, 532,
iast_HARDCODED_SECRET_DISABLED (501.444 µs) : 480, 523
. : milestone, 501,
iast_INACTIVE (457.734 µs) : 436, 480
. : milestone, 458,
iast_TELEMETRY_OFF (492.882 µs) : 470, 515
. : milestone, 493,
tracing (453.478 µs) : 432, 475
. : milestone, 453,
section candidate
no_agent (383.108 µs) : 363, 403
. : milestone, 383,
iast (503.41 µs) : 481, 525
. : milestone, 503,
iast_FULL (658.841 µs) : 637, 681
. : milestone, 659,
iast_GLOBAL (525.767 µs) : 504, 548
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (490.967 µs) : 469, 512
. : milestone, 491,
iast_INACTIVE (456.225 µs) : 435, 478
. : milestone, 456,
iast_TELEMETRY_OFF (488.724 µs) : 467, 510
. : milestone, 489,
tracing (449.432 µs) : 429, 470
. : milestone, 449,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
. : milestone, 1351,
appsec (1.749 ms) : 1725, 1772
. : milestone, 1749,
appsec_no_iast (1.732 ms) : 1709, 1755
. : milestone, 1732,
iast (1.514 ms) : 1492, 1536
. : milestone, 1514,
profiling (1.542 ms) : 1517, 1567
. : milestone, 1542,
tracing (1.466 ms) : 1441, 1492
. : milestone, 1466,
section candidate
no_agent (1.352 ms) : 1333, 1372
. : milestone, 1352,
appsec (1.74 ms) : 1717, 1764
. : milestone, 1740,
appsec_no_iast (1.758 ms) : 1735, 1781
. : milestone, 1758,
iast (1.535 ms) : 1512, 1558
. : milestone, 1535,
profiling (1.562 ms) : 1537, 1586
. : milestone, 1562,
tracing (1.493 ms) : 1467, 1518
. : milestone, 1493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1450, 1473
. : milestone, 1462,
appsec (2.343 ms) : 2301, 2386
. : milestone, 2343,
iast (2.096 ms) : 2042, 2150
. : milestone, 2096,
iast_GLOBAL (2.137 ms) : 2083, 2191
. : milestone, 2137,
profiling (1.972 ms) : 1928, 2016
. : milestone, 1972,
tracing (1.936 ms) : 1895, 1978
. : milestone, 1936,
section candidate
no_agent (1.461 ms) : 1450, 1472
. : milestone, 1461,
appsec (2.346 ms) : 2303, 2388
. : milestone, 2346,
iast (2.088 ms) : 2034, 2142
. : milestone, 2088,
iast_GLOBAL (2.13 ms) : 2076, 2185
. : milestone, 2130,
profiling (1.975 ms) : 1931, 2019
. : milestone, 1975,
tracing (1.927 ms) : 1886, 1969
. : milestone, 1927,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~e5bd885390, baseline=1.45.0-SNAPSHOT~4e795042e9
dateFormat X
axisFormat %s
section baseline
no_agent (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
appsec (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
iast (18.751 s) : 18751000, 18751000
. : milestone, 18751000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
. : milestone, 17981000,
profiling (15.635 s) : 15635000, 15635000
. : milestone, 15635000,
tracing (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
section candidate
no_agent (15.243 s) : 15243000, 15243000
. : milestone, 15243000,
appsec (15.24 s) : 15240000, 15240000
. : milestone, 15240000,
iast (18.704 s) : 18704000, 18704000
. : milestone, 18704000,
iast_GLOBAL (18.107 s) : 18107000, 18107000
. : milestone, 18107000,
profiling (15.527 s) : 15527000, 15527000
. : milestone, 15527000,
tracing (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
|
What Does This Do
disable telemetry for MethodHandle lookups
can happen frequently (every startup on jdk8)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]