Skip to content

Conversation

@cx-ricardo-jesus
Copy link
Contributor

Closes #

Reason for Proposed Changes

  • Currently, for experimental queries, it returns the YetToBeChecked transition type, and it should be returning the NonGracefullyTransition transition type, since this type of queries do not have any old similarityId.

Proposed Changes

  • Added an extra boolean argument inside the checkQueryTransitionType that basically, checks if the query is experimental or not, in case the query is experimental, it just returns the transition type NonGracefullTransition.
  • On the generateSimilatiesID function, when getting the transitionType using the checkQueryTransitionType, it takes into account, the value of the Experimental field on the queries metadata.
  • On the vulnerability_builder_transition_test.go file, added the experimental field on the tests, because, now the function checkQueryTransitionType takes an extra argument, as mentioned above.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner November 3, 2025 11:58
@github-actions github-actions bot added the query New query feature label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

kics-logo

KICS version: v2.1.13

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-ricardo-jesus cx-ricardo-jesus changed the title fix(transition): experimental queries get NonGraceffulyTransition type fix(transition): experimental queries get NonGraceffulyTransition transition type Nov 3, 2025
cx-miguel-silva
cx-miguel-silva previously approved these changes Nov 5, 2025
@cx-miguel-silva cx-miguel-silva merged commit 3d716f2 into master Nov 5, 2025
26 of 29 checks passed
@cx-miguel-silva cx-miguel-silva deleted the nonGracefull-status-for-beta-queries branch November 5, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query New query feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants