fix(transition): experimental queries get NonGraceffulyTransition transition type (#7809)

* experimental queries getting NonGracefullyTransition type

* some changes

* gofmt changes

* fix function declaration exceding 140 characters

* gofmt changes

* fixed golint problems

* just to check something

* trying to fix e2e_070 test problems

* changed the result for the E2E_CLI_070 test case

* fixed identation

* fixed identation

* added new line

Author: cx-ricardo-jesus

e2e/fixtures/E2E_CLI_070_RESULT.json

@@ -20,8 +20,8 @@
   },
   "total_counter": 2,
   "total_bom_resources": 0,
-  "start": "2024-05-28T13:18:56.6040425+01:00",
-  "end": "2024-05-28T13:18:56.948862+01:00",
+  "start": "2025-11-05T12:30:29.616176853Z",
+  "end": "2025-11-05T12:30:30.07811478Z",
   "paths": [
     "/path/test/fixtures/experimental_test/sample",
     "/path/test/fixtures/experimental_test/queries"
@@ -41,7 +41,7 @@
       "files": [
         {
           "file_name": "path\\test\\fixtures\\experimental_test\\sample\\sample.tf",
-          "similarity_id": "4e651f5c005de96ab66f25419b1f160d9e0eecae83181edfcd1b72b3afbe9f69",
+          "similarity_id": "efa296e727d250c75a82c32c397e4e78d4b87434373312b34d970ec260f0aa15",
           "line": 4,
           "resource_type": "aws_elasticache_cluster",
           "resource_name": "cluster-example",

pkg/engine/vulnerability_builder.go

@@ -219,7 +219,7 @@ func generateSimilaritiesID(ctx *QueryContext, resolvedFile, subDocumentIdx, que
 	searchKey, oldSimilarityIDLineInfo string, kicsComputeNewSimID bool, logWithFields *zerolog.Logger, tracker Tracker,
 	kicsMigrationQueryInfo map[string]TransitionQueryInfo,
 ) (similarityID, oldSimilarityID *string) {
-	transitionType := checkQueryTransitionType(kicsMigrationQueryInfo, queryID)
+	transitionType := checkQueryTransitionType(kicsMigrationQueryInfo, queryID, ctx.Query.Metadata.Experimental)
 	// only will generate pair of similarity IDs if the scan flag is enabled and the transition type is not YetToBeChecked
 	// or if the scan flag is disabled and the transition type is NonGracefullyTransition
 	if kicsComputeNewSimID && transitionType != YetToBeChecked ||

pkg/engine/vulnerability_builder_transition.go

@@ -28,9 +28,16 @@ type TransitionQueryInfo struct {
 	Observation string                         `yaml:"observation"`
 }
 
-func checkQueryTransitionType(changeList map[string]TransitionQueryInfo, queryID string) VulnerabilityBuilderTransition {
+func checkQueryTransitionType(
+	changeList map[string]TransitionQueryInfo,
+	queryID string,
+	isExperimental bool,
+) VulnerabilityBuilderTransition {
 	if change, ok := changeList[queryID]; ok {
 		return change.Transition
 	}
+	if isExperimental {
+		return NonGracefullyTransition
+	}
 	return YetToBeChecked
 }

pkg/engine/vulnerability_builder_transition_test.go

@@ -31,50 +31,68 @@ var testTransitionQueryInfo = map[string]TransitionQueryInfo{
 		QueryName:  "Query4",
 		Transition: 4,
 	},
+	"b9b7ada8-3868-4a35-854e-6100a2bb863d": {
+		QueryID: "b9b7ada8-3868-4a35-854e-6100a2bb863d",
+		QueryName: "Query6",
+		Transition: 1,
+	},
 }
 
 func TestCheckQueryTransitionType(t *testing.T) {
 
 	tests := []struct {
-		name     string
-		changeID string
-		expected VulnerabilityBuilderTransition
+		name         string
+		changeID     string
+		experimental bool
+		expected     VulnerabilityBuilderTransition
 	}{
 		{
-			name:     "Query with transition type 3 - AddedSearchValue ",
-			changeID: "1828a670-5957-4bc5-9974-47da228f75e2",
-			expected: AddedSearchValue,
+			name:         "Query with transition type 3 - AddedSearchValue ",
+			changeID:     "1828a670-5957-4bc5-9974-47da228f75e2",
+			experimental: false,
+			expected:     AddedSearchValue,
+		},
+		{
+			name:         "Query with transition type 5 - AddedSearchValueAndAddedSearchLine",
+			changeID:     "cf34805e-3872-4c08-bf92-6ff7bb0cfadb",
+			experimental: false,
+			expected:     AddedSearchValueAndAddedSearchLine,
 		},
 		{
-			name:     "Query with transition type 5 - AddedSearchValueAndAddedSearchLine",
-			changeID: "cf34805e-3872-4c08-bf92-6ff7bb0cfadb",
-			expected: AddedSearchValueAndAddedSearchLine,
+			name:         "Query with transition type 1 - NonGracefullyTransition",
+			changeID:     "c3162390-7f18-4f31-8c73-da1d86c8a11e",
+			experimental: false,
+			expected:     NonGracefullyTransition,
 		},
 		{
-			name:     "Query with transition type 1 - NonGracefullyTransition",
-			changeID: "c3162390-7f18-4f31-8c73-da1d86c8a11e",
-			expected: NonGracefullyTransition,
+			name:         "Query with transition type 2 - TransitionWithoutChanges",
+			changeID:     "788996a7-4359-4568-9a91-1ad0c4112818",
+			experimental: false,
+			expected:     TransitionWithoutChanges,
 		},
 		{
-			name:     "Query with transition type 2 - TransitionWithoutChanges",
-			changeID: "788996a7-4359-4568-9a91-1ad0c4112818",
-			expected: TransitionWithoutChanges,
+			name:         "Query with transition type 4 - AddedSearchLine",
+			changeID:     "77f5d46e-7244-4606-80c6-18478627aa9e",
+			experimental: false,
+			expected:     AddedSearchLine,
 		},
 		{
-			name:     "Query with transition type 4 - AddedSearchLine",
-			changeID: "77f5d46e-7244-4606-80c6-18478627aa9e",
-			expected: AddedSearchLine,
+			name:     	  "Query with transition type 0 - YetToBeChecked",
+			changeID:     "non-existing-query-id",
+			experimental: false,
+			expected:     YetToBeChecked,
 		},
 		{
-			name:     "Query with transition type 0 - YetToBeChecked",
-			changeID: "non-existing-query-id",
-			expected: YetToBeChecked,
+			name:         "Query with transition type 1 - NonGracefullyTransition (experimental query)",
+			changeID:     "b9b7ada8-3868-4a35-854e-6100a2bb863d",
+			experimental: true,
+			expected:     NonGracefullyTransition,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := checkQueryTransitionType(testTransitionQueryInfo, tt.changeID)
+			result := checkQueryTransitionType(testTransitionQueryInfo, tt.changeID, tt.experimental)
 			require.Equal(t, tt.expected, result)
 		})
 	}