Add support for viewing tiles in iso orientation #588
Conversation
|
Thanks @david-lively! |
| ##### Fixes :wrench: | ||
| - Fixed tile culling when in orthographic view. |
There was a problem hiding this comment.
Sorry for my late comment, I'm wondering if we should position this as an addition instead? (The original issue was labelled "enhancement".)
There was a problem hiding this comment.
I'm not sure I agree. Before this PR, one could still switch the Unity camera to orthographic; it just didn't work correctly.
There was a problem hiding this comment.
We should put it in "Breaking Changes". Someone may have been relying on the previous behavior where orthographic cameras didn't load tiles.
Just kidding of course! I think a reasonable case can be made for either Fixes or Additions, though.
There was a problem hiding this comment.
Putting it in Additions would let us bump up our minor version number 😄 But I don't mean to bikeshed, it's fine either way.
This PR adds support for Orthographic projection. When generating a
ViewStatefrom the UnityCamera, we now determine if the camera is using orthographic project and, if so, generate the correct correspondingViewState.When
Camera.orthographicistrue, theCamera.orthographicSizeindicates half of the height of the view volume in meters. (See Unity's Camera.orthographicSize documentation for more detail on configuring the camera. )In the Unity Inspector, these properties are listed under the Projection rollout. The
Sizeproperty corresponds to the script propertyCamera.orthographicSize.Note that this PR modifies
Runtime/ConfigureReinterop.csto allow native access toCamera::orthographic()andCamera::orthographicSize(). Therefore, the Cesium Unity DLL will need to be recompiled.