Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Conversation

@nh916
Copy link
Contributor

@nh916 nh916 commented Jan 4, 2023

The main reason I am thinking of creating a release is that there needs to be a new patch for the Python SDK that must be released for it to work with the new API

rjmello and others added 30 commits October 27, 2022 17:56
Add simulation tutorial to docs
Set get_level default value to 1
Updated error handling with more descriptive message
added badges and made the links a bit cleaner
* added a colored logo with white background to the top

* Added more explanation about the Repo within the README.md
… installation section

Adding python 3.9+ is required in the installation section
updated MIT license link
capitalizing Python everywhere to stay consistent
Updated alt text to make it more understandable
created better error for invalid storage authentication code
Improve UniqueNodeError for usability
Ludwig Schneider and others added 6 commits December 19, 2022 09:12
                                                                                                                        

�[2K�[1A�[2KChecking 88% [===============================================================================>           ]  84/95  0.2s
 ↳ prettier
   ↳ .github/ISSUE_TEMPLATE/bug_report.md... (5 files) ⠙
   ↳ .github/workflows/pytest.yml... (5 files) ⠙
                                                                                                                        

�[2K�[1A�[2K�[1A�[2K�[1A�[2K�[1A�[2KChecking 99% [=========================================================================================> ]  94/95  0.4s
 ↳ trunk
   ↳ Aggregating results ⠹
                                                                                                                        

�[2K�[1A�[2K�[1A�[2K�[1A�[2KChecking 100% [=========================================================================================>]  95/95  0.5s

Checked 56 modified files
�[1m�[92m✔ No issues
�[0m
Add automatic testing with pytest
patching create node issue within the utils.py. Removing "can_edit" from API response
@InnocentBug
Copy link

well, this shouldn't fail the test before we release, right?

@nh916
Copy link
Contributor Author

nh916 commented Jan 5, 2023

@InnocentBug I agree it should not, but I have not checked the tests and am not sure if its a problem with the tests, the code, or something else

@nh916 nh916 requested a review from brili January 5, 2023 00:39
@dylanwal
Copy link
Contributor

dylanwal commented Jan 5, 2023

I agree with Ludwig about test. Can you look through the test and either update or delete the irrelevant test?

@nh916 nh916 temporarily deployed to testing January 11, 2023 22:12 — with GitHub Actions Inactive
@nh916 nh916 temporarily deployed to testing January 11, 2023 22:12 — with GitHub Actions Inactive
@nh916 nh916 requested a review from CVilla17 January 11, 2023 22:14
@nh916
Copy link
Contributor Author

nh916 commented Jan 12, 2023

@brili I think the current tests are being ran against the master branch of criptapp, is there a way we can run these tests against staging or development branch of criptapp as well because currently those are different

@nh916
Copy link
Contributor Author

nh916 commented Jan 12, 2023

Let me know if the changes I made need more comments, and I can add them in for clarity.

@brili brili merged commit 2a01e50 into master Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants