Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Conversation

@nh916
Copy link
Contributor

@nh916 nh916 commented Jan 4, 2023

Discovered this issue with the new API on staging and develop servers. API gives back a "can_edit" filed within the JSON, but that is not used for python SDK or the Excel Uploader but is used in the Web SDK for criptapp

@InnocentBug
Copy link

I have seen the failure before, but couldn't quite figure out of how to fix it.

@nh916
Copy link
Contributor Author

nh916 commented Jan 4, 2023

@InnocentBug just glad we got another thing crossed off!

I noticed some checks were failing, is that okay or is there something that I need to do before merging in?

@InnocentBug
Copy link

should be fine to merge now.
But at some point we should take a look.
My comment was more meant to mean, that you didn't introduce this failing with this PR.

@nh916 nh916 merged commit 1f016e4 into develop Jan 4, 2023
@nh916 nh916 deleted the patch_create_node branch January 4, 2023 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants