Inspector v2: umd cdn #17379
Inspector v2: umd cdn #17379
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17379/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17379/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17379/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
3 participants
This is a follow up to my initial umd package PR: #17357
In the initial PR, the path I went was to redirect
inspectortoinspector-v2in the context of the Inspector v2 build, since they ultimately are the same package with different versions (v2 having the-prefixsuffix). This was simpler, but it turns out doesn't work with the way we publish umd bundles to our cdn. For that, we need unique entries in the package mappings, so now I've added a separate entry for inspector-v2. This gets used by the prepareSnapshot script to determine what gets copied to the cdn. The way I set it up is the inspector v2 bundle gets copied to the inspector directory, but with a new unique name (babylon.inspector-v2.bundle.js). I tested the snapshot copy locally, but in the process I noticed that we were copying webpack.config.js files to the cdn (because they match the *.js glob). For example: https://cdn.babylonjs.com/webpack.config.js. @docEdub - we should probably try to figure out how to remove all these webpack.config.js files from the cdn.For now I'm making this PR draft so that I can verify the snapshot cdn functionality before merging, and also I don't want to touch any cdn publishing related stuff on a Friday afternoon. :)