Inspector v2: umd package #17357
Inspector v2: umd package #17357
Conversation
Add babylonjs-inspector-v2 in top level umd build
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17357/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17357/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17357/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17357/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17357/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
This is a follow up to my initial umd package PR: #17357 In the initial PR, the path I went was to redirect `inspector` to `inspector-v2` in the context of the Inspector v2 build, since they ultimately are the same package with different versions (v2 having the `-prefix` suffix). This was simpler, but it turns out doesn't work with the way we publish umd bundles to our cdn. For that, we need unique entries in the package mappings, so now I've added a separate entry for inspector-v2. This gets used by the prepareSnapshot script to determine what gets copied to the cdn. The way I set it up is the inspector v2 bundle gets copied to the inspector directory, but with a new unique name (babylon.inspector-v2.bundle.js). I tested the snapshot copy locally, but in the process I noticed that we were copying webpack.config.js files to the cdn (because they match the *.js glob). For example: https://cdn.babylonjs.com/webpack.config.js. @docEdub - we should probably try to figure out how to remove all these webpack.config.js files from the cdn. For now I'm making this PR draft so that I can verify the snapshot cdn functionality before merging, and also I don't want to touch any cdn publishing related stuff on a Friday afternoon. :)
3 participants
This is the initial implementation of the Inspector v2 umd package. We need this for a few reasons:
The inspector v2 js bundle has a -v2 in the name, so it will not conflict with Inspector v2 when deployed to the Babylon CDN.
After this change goes in, I will have to update the pipeline to have the extra steps for publishing Inspector v2 as babylonjs-inspector@preview (basically the same as what has already been done with @babylonjs/inspector@preview).