-
Notifications
You must be signed in to change notification settings - Fork 378
ImdsV2: Entra Request: "expires_in" is now lumped into "expires_on" #5494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Robbie-Microsoft
merged 6 commits into
rginsburg/msiv2_feature_branch
from
rginsburg/msiv2_expires_in
Sep 24, 2025
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0692a8e
Implemented expires_in
Robbie-Microsoft 2fd8bd7
public -> private
Robbie-Microsoft ee7f540
undo last change
Robbie-Microsoft 8b86d5c
small adjustment to validation
Robbie-Microsoft 468d651
Implemented feedback
Robbie-Microsoft 9c5453e
Merge branch 'rginsburg/msiv2_feature_branch' into rginsburg/msiv2_ex…
Robbie-Microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| #if SUPPORTS_SYSTEM_TEXT_JSON | ||
| using Microsoft.Identity.Client.Platforms.net; | ||
| using JsonProperty = System.Text.Json.Serialization.JsonPropertyNameAttribute; | ||
| using JsonIgnore = System.Text.Json.Serialization.JsonIgnoreAttribute; | ||
| #else | ||
| using Microsoft.Identity.Json; | ||
| #endif | ||
|
|
@@ -29,8 +30,22 @@ internal class ManagedIdentityResponse | |
| /// </summary> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How will we keep this object |
||
| /// <remarks>The date is represented as the number of seconds from "1970-01-01T0:0:0Z UTC" | ||
| /// (corresponds to the token's exp claim).</remarks> | ||
| [JsonIgnore] | ||
| public string ExpiresOn { get; set; } // The actual property consumers use | ||
Robbie-Microsoft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| [JsonProperty("expires_on")] | ||
| public string ExpiresOn { get; set; } | ||
| public string ExpiresOnRaw // Proxy for "expires_on" JSON field | ||
| { | ||
| get => ExpiresOn; // When serializing, return ExpiresOn value | ||
| set => ExpiresOn = value; // When deserializing, store in ExpiresOn | ||
| } | ||
|
|
||
| [JsonProperty("expires_in")] | ||
| public string ExpiresInRaw // Proxy for "expires_in" JSON field | ||
| { | ||
| get => null; // Never serialize this (return null) | ||
| set => ExpiresOn = value; // When deserializing, store in ExpiresOn | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The resource the access token was requested for. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.