ImdsV2: Entra Request: "expires_in" is now lumped into "expires_on" #5494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Robbie-Microsoft
commented
Sep 22, 2025
Robbie-Microsoft
commented
- Manually tested on tip node
- All existing unit tests pass
gladjohn
reviewed
Sep 23, 2025
bgavrilMS
reviewed
Sep 23, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityResponse.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 23, 2025
|
|
||
| /// <summary> | ||
| /// The timespan when the access token expires. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
How will we keep this object ManagedIdentityResponse in sync with MsalTokenResponse, e.g. RefreshIn is missing?
bgavrilMS
reviewed
Sep 23, 2025
bgavrilMS
reviewed
Sep 23, 2025
src/client/Microsoft.Identity.Client/ManagedIdentity/ManagedIdentityResponse.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Sep 24, 2025
Robbie-Microsoft
merged commit d180eb1
into
rginsburg/msiv2_feature_branch
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.