Add GroupBy method for Z.DynamicLinq.SystemTextJson and Z.DynamicLinq.NewtonsoftJson #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the GroupBy extension method for both System.Text.Json and NewtonsoftJson, enhancing query capabilities on JSON collections. Key changes include:
- Adding tests for the new GroupBy functionality in both JSON test projects.
- Introducing two overloads for GroupBy in each extension class (one with default config and one accepting a custom config).
- Updating resource handling by switching to "using" declarations when parsing JSON.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/System.Linq.Dynamic.Core.SystemTextJson.Tests/SystemTextJsonTests.cs | Adds GroupBy tests and updates JSON parsing to use disposal with "using". |
| test/System.Linq.Dynamic.Core.NewtonsoftJson.Tests/NewtonsoftJsonTests.cs | Adds GroupBy tests for the NewtonsoftJson implementation. |
| src/System.Linq.Dynamic.Core.SystemTextJson/SystemTextJsonExtensions.cs | Introduces GroupBy extension methods for JsonDocument with overloads and updated conversion logic for grouping. |
| src/System.Linq.Dynamic.Core.NewtonsoftJson/NewtonsoftJsonExtensions.cs | Adds GroupBy extension methods for JArray with overloads and updated conversion logic for grouping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.