Skip to content

Conversation

@StefH
Copy link
Collaborator

@StefH StefH commented May 15, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to ensure that a ParsingConfig is not passed as an argument in the wrong position by throwing an appropriate ArgumentException. It updates tests to verify the error message, adds a new Args check in Check.cs, and updates DynamicQueryableExtensions to consistently call Check.Args.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/System.Linq.Dynamic.Core.Tests/QueryableTests.Where.cs Adds a test verifying the new ParsingConfig validation error message.
test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs Updates method call order to pass config as the first parameter.
src/System.Linq.Dynamic.Core/Validation/Check.cs Introduces Check.Args for validating argument order regarding ParsingConfig.
src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs Inserts Check.Args validations in various query extension methods to enforce the new argument order.
Comments suppressed due to low confidence (1)

src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs:688

  • [nitpick] Review the removal of explicit parameter name arguments in Check.NotEmpty calls to ensure that CallerArgumentExpression yields the expected parameter names in all contexts.
Check.NotEmpty(keySelector);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants