Improve string manipulation performance #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying StringComparison.Ordinal where possible will make operations faster, especially for large queries, especially when running on Linux. The culture sesitive string operations are significantly slower on Linux compared to Windows (dotnet/runtime#37919).
Member
|
Hello @cosminvlad , The v3.2.3 has been released with your fix. Thank you for your contribution ;) Best Regards, Jon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
StringComparison.OrdinalorStringComparison.OrdinalIgnoreCasewhere possible will make operations faster, especially for large queries, especially when running on Linux. The culture sensitive string operations are significantly slower on Linux compared to Windows (dotnet/runtime#37919).I have found
SetParameterListto be a small hotspot in an app that uses particularly large queries (7-8 table joins, lots of columns for each).