Clean up RSS14Reader #631
Open
Clean up RSS14Reader #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opl-
force-pushed
the
feat/clean-up-rss14reader
branch
from
755a2dc to
2fc10e6
Compare
|
Thank you for all the PRs, much appreciated!!! I will take a look after my vacation! 👍🏻 |
werthdavid
reviewed
Dec 1, 2024
|
Can you rebase that and resolve the conflicts? |
let -> const, initialize numbers, change equality operator, add missing comments.
opl-
force-pushed
the
feat/clean-up-rss14reader
branch
from
2fc10e6 to
724d31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported zxing/zxing#1179, changed a bunch of
lettoconstwhere appropriate, copied over a couple comments, initialized some variables, changed==to===, and fixed thrown errors getting eaten in one place.