Skip to content

Conversation

shahrin014
Copy link

@shahrin014 shahrin014 commented Aug 11, 2021

Fixed the following to allow tests to run

  • Removed duplicate import (and shifted it's position to prevent merge conflict with master later)
  • Explicitly specify assert function return value, to prevent typescript errors:
src/test/core/pdf417/decoder/PDF417Decoder.spec.ts:131:5 - error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.

131     assertEquals(260013, resultMetadata.getChecksum());
        ~~~~~~~~~~~~

  src/test/core/util/AssertUtils.ts:23:14
    23 export const assertEquals = assert.strictEqual;
                    ~~~~~~~~~~~~
    'assertEquals' needs an explicit type annotation.

@werthdavid werthdavid merged commit 9f32092 into zxing-js:feature/multi-qr-code-reader Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants