Skip to content

Conversation

@markus-oberhumer-forks
Copy link

Moving __GLIBC__ to the top is needed so that commits f9c9ae8 and 0afead5 actually work.

Copy link
Contributor

@rootbeer rootbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@markus-oberhumer
Copy link
Contributor

This patch was successfully tested with 17 glibc versions from 2.3.3 to 2.38 here:
https://github.com/upx/upx-test-build-with-zig/actions/runs/8424304671

@Vexu Vexu merged commit 59203cb into ziglang:master Mar 26, 2024
@markus-oberhumer-forks markus-oberhumer-forks deleted the improve-old-glibc-versions branch April 3, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants