-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add zig cc support for LLVM flag --no-undefined-version follow up from #17326
#18255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zig cc support for LLVM flag --no-undefined-version follow up from #17326
#18255
Conversation
Co-authored-by: Motiejus Jakštys <[email protected]>
…hS/zig into add-no-undefined-version-linker-arg
…hS/zig into add-no-undefined-version-linker-arg
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
…hS/zig into add-no-undefined-version-linker-arg
Co-authored-by: Samuel Cantero <[email protected]>
Co-authored-by: Samuel Cantero <[email protected]>
|
@behos Sorry to tag you in multiple places but just so you don't miss it, I opened a PR with some fixes and additions to your fork.
|
479a91b to
35ccedb
Compare
35ccedb to
db21d79
Compare
|
@castholm Could you do another check for your changes? I had to do a merge and restructure the integration points a bit. |
|
@behos I might be able to try in a bit, first I need to get my SDL project working again with the newest build system changes. Will report back. |
|
@behos Didn't work, the flag isn't currently being propagated and there are also some additional problems that need fixing. Since I have a project to test with and it might be easier for me to re-test whenever the branch needs rebasing, would you be fine with it if I just fork your branch and open a third PR with the fixes? |
|
@castholm yes, go ahead :) |
Following up from this PR #17326 to unblock it by applying the formatting fix.
Happy to close this PR if the original one is updated of course :)
All credit goes to https://github.com/DhashS