Skip to content

Conversation

@behos
Copy link
Contributor

@behos behos commented Dec 11, 2023

Following up from this PR #17326 to unblock it by applying the formatting fix.

Happy to close this PR if the original one is updated of course :)

All credit goes to https://github.com/DhashS

DhashS and others added 30 commits September 29, 2023 13:38
Co-authored-by: Motiejus Jakštys <[email protected]>
…hS/zig into add-no-undefined-version-linker-arg
…hS/zig into add-no-undefined-version-linker-arg
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Motiejus Jakštys <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
Co-authored-by: Jakub Konka <[email protected]>
…hS/zig into add-no-undefined-version-linker-arg
Co-authored-by: Samuel Cantero <[email protected]>
@castholm
Copy link
Contributor

@behos Sorry to tag you in multiple places but just so you don't miss it, I opened a PR with some fixes and additions to your fork.

DataDog#1

  • main.zig did not handle the option correctly, which meant that zig build-lib --undefined-version ... didn't actually work and instead printed an "unrecognized parameter" error message. The first commit fixes this.
  • The second commit exposes the option to the build system. (I'm working on a port of SDL3 to the zig build system which needs to pass this option in order to build successfully.)

I've tested the changes locally (both the standard and --no- variants) and can confirm they work correctly now.

@behos behos force-pushed the add-no-undefined-version-linker-arg branch 8 times, most recently from 479a91b to 35ccedb Compare January 4, 2024 12:01
@behos behos force-pushed the add-no-undefined-version-linker-arg branch from 35ccedb to db21d79 Compare January 4, 2024 12:02
@behos
Copy link
Contributor Author

behos commented Jan 4, 2024

@castholm Could you do another check for your changes? I had to do a merge and restructure the integration points a bit.

@castholm
Copy link
Contributor

castholm commented Jan 4, 2024

@behos I might be able to try in a bit, first I need to get my SDL project working again with the newest build system changes. Will report back.

@castholm
Copy link
Contributor

castholm commented Jan 5, 2024

@behos Didn't work, the flag isn't currently being propagated and there are also some additional problems that need fixing.

Since I have a project to test with and it might be easier for me to re-test whenever the branch needs rebasing, would you be fine with it if I just fork your branch and open a third PR with the fixes?

@behos
Copy link
Contributor Author

behos commented Jan 8, 2024

@castholm yes, go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants