Drivers: i2c: target eeprom extra api #96918
Open
+142
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarmouniA
changed the title
henrikbrixandersen
requested changes
Oct 17, 2025
kartben
previously requested changes
Oct 17, 2025
jacmet
force-pushed
the
feature/i2c-target-eeprom-extra-api
branch
from
b0061a2 to
c0f24a0
Compare
|
Changes since v1:
|
jacmet
force-pushed
the
feature/i2c-target-eeprom-extra-api
branch
from
c0f24a0 to
78cb854
Compare
|
Changes since v2:
|
For some use cases it can be interesting to know when the eeprom has been written to by the I2C host (E.G. once a stop has been received after a write transaction), so add a "changed" callback. Multiple EEPROM instances are supported, so pass the device and user data as arguments to the callback. Signed-off-by: Peter Korsgaard <[email protected]>
For some use cases it can be interesting to know how big the EEPROM is, so add a getter for it. Signed-off-by: Peter Korsgaard <[email protected]>
The current functions to access the EEPROM data are not ideal, E.G.: - eeprom_target_program() is hard coded to write to the beginning of the EEPROM data - eeprom_target_read() reads a single byte, so large overhead to read all data So as an alternative, add an interface similar to what is provided by zephyr/drivers/eeprom.h, E.G. functions taking an offset and and length. Signed-off-by: Peter Korsgaard <[email protected]>
jacmet
force-pushed
the
feature/i2c-target-eeprom-extra-api
branch
from
78cb854 to
4006a1a
Compare
zephyrbot
added
the
area: Tests
…ta() eeprom_target_program() is about to become deprecated as it does not take an offset argument, so switch to eeprom_target_write_data() instead. Signed-off-by: Peter Korsgaard <[email protected]>
It does not provide an offset argument, so suggest eeprom_target_write_data() instead. Signed-off-by: Peter Korsgaard <[email protected]>
It is not very handy that the EEPROM stops responding after 1 second, so drop that. Signed-off-by: Peter Korsgaard <[email protected]>
And show the usages of the new _get_size() / _get_data() getters. Signed-off-by: Peter Korsgaard <[email protected]>
jacmet
force-pushed
the
feature/i2c-target-eeprom-extra-api
branch
from
4006a1a to
33696a3
Compare
|
Changes since v4:
|
|
kartben
dismissed
their stale review
comment addressed - thank you (sorry that I can't really provide an actual review :|)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some use cases it can be interesting to know when the eeprom has been written to by the I2C host (E.G. once a stop has been received after a write transaction), so add a "changed" callback.
The existing API for accessing the EEPROM data is not ideal, so add getters for the size and data instead and update the sample the use the new APIs