Skip to content

Conversation

@erikarn
Copy link

@erikarn erikarn commented Oct 17, 2024

this is a WIP (i haven't even checkpatched it!) to address Issues #79823 and Issue #79825

@zephyrbot zephyrbot added area: USB Universal Serial Bus area: Samples Samples platform: STM32 ST Micro STM32 labels Oct 17, 2024
@github-actions
Copy link

Hello @erikarn, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@jfischer-no
Copy link
Contributor

Can you please familiarize yourself with how to write commit titles and messages, and the PR submission process? Read the link posted by the bot above. Use git log to get an idea of how to write commit messages.

@erikarn
Copy link
Author

erikarn commented Oct 17, 2024

Can you please familiarize yourself with how to write commit titles and messages, and the PR submission process? Read the link posted by the bot above. Use git log to get an idea of how to write commit messages.

oh absolutely, I'm slowly massaging this into the right shape. I just wanted to first make sure I got the code somewhere in case I got busy!

@kartben
Copy link
Contributor

kartben commented Oct 18, 2024

Can you please familiarize yourself with how to write commit titles and messages, and the PR submission process? Read the link posted by the bot above. Use git log to get an idea of how to write commit messages.

oh absolutely, I'm slowly massaging this into the right shape. I just wanted to first make sure I got the code somewhere in case I got busy!

You might want to set the PR as draft in the meantime so that reviewers know it's not ready for review just yet (but you might still get early feedback and, to your point, this would have the merit of putting the code somewhere :))

@erikarn
Copy link
Author

erikarn commented Oct 18, 2024

Ok! Lemme go find how to mark it as draft, I've not done that before! heh

@erikarn erikarn marked this pull request as draft October 18, 2024 17:35
@erikarn erikarn force-pushed the main branch 3 times, most recently from c576369 to 1aaaf6e Compare October 21, 2024 17:13
@erikarn erikarn closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Samples Samples area: USB Universal Serial Bus platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants