libc/picolibc: Picolibc fixes #58462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-packard
requested review from
dcpleung,
microbuilder and
nashif
as code owners
zephyrbot
added
area: Userspace
zephyrbot
added
manifest
manifest-sof
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
60 tasks
joerchan
reviewed
May 31, 2023
joerchan
previously approved these changes
May 31, 2023
microbuilder
previously approved these changes
May 31, 2023
dcpleung
reviewed
May 31, 2023
This conflicts with what the compiler expects for the definition of 'main' when -ffreestanding is not used. Signed-off-by: Keith Packard <[email protected]>
The default malloc arena when using picolibc is too large for the hifive1_revb target. Signed-off-by: Keith Packard <[email protected]>
… zero This test fails when using picolibc with the default malloc arena value. Fix this by explicitly setting the malloc arena size to zero, as when using the minimal C library. Signed-off-by: Keith Packard <[email protected]>
keith-packard
dismissed stale reviews from microbuilder and joerchan
via
522439a
keith-packard
force-pushed
the
picolibc-fixes
branch
from
e5900b6 to
522439a
Compare
zephyrbot
added
area: Portability
|
I moved the modules/audio/sof fix out of this PR as that didn't fit the other changes here which are all minor fixes to samples. |
dcpleung
approved these changes
Jun 16, 2023
microbuilder
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a handful of fixes required to use picolibc as the default C library